Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand avworkflow_run argument option #65

Closed
shbrief opened this issue Sep 27, 2022 · 4 comments
Closed

Expand avworkflow_run argument option #65

shbrief opened this issue Sep 27, 2022 · 4 comments

Comments

@shbrief
Copy link
Contributor

shbrief commented Sep 27, 2022

Hi Martin,

Can we make the entityName argument of avworkflow_run take NULL as well? Because my bioBakery workflow doesn’t use Terra’s data model, I should set it NULL, which currently gives me this error: .is_scalar_character(entityName) is not TRUE. Thanks!

Sehyun

@LiNk-NY
Copy link
Contributor

LiNk-NY commented Sep 27, 2022

Hi Sehyun,
Can you provide a reproducible example?
Have you tried using a blank ""?
Best,
Marcel

@shbrief
Copy link
Contributor Author

shbrief commented Oct 4, 2022

For avworkflow_run, both NULL and "" are not working:

> avworkflow_run(
+     config,
+     entityName = NULL,
+     entityType = NULL,
+     useCallCache = TRUE,
+     namespace = "waldronlab-terra-rstudio",
+     name = "biobakery_test",
+     dry = FALSE    
+ )
Error in avworkflow_run(config, entityName = NULL, entityType = NULL,  : 
  .is_scalar_character(entityName) is not TRUE
> avworkflow_run(
+     config,
+     entityName = "",
+     entityType = "",
+     useCallCache = TRUE,
+     namespace = "waldronlab-terra-rstudio",
+     name = "biobakery_test",
+     dry = FALSE    
+ )
Error in avworkflow_run(config, entityName = "", entityType = "", useCallCache = TRUE,  : 
  .is_scalar_character(entityName) is not TRUE

But Terra()$createSubmission works with NULL:

> resp <- Terra()$createSubmission(
+     workspaceNamespace = "waldronlab-terra-rstudio",
+     workspaceName = "biobakery_test",
+     methodConfigurationNamespace = "mtx_workflow_biobakery_version3",
+     methodConfigurationName = "mtx_workflow_biobakery_version3",
+     entityType = NULL,
+     entityName = NULL,
+     useCallCache = TRUE
+ )
> resp
Response [https://api.firecloud.org/api/workspaces/waldronlab-terra-rstudio/biobakery_test/submissions]
  Date: 2022-10-04 18:31
  Status: 201
  Content-Type: application/json
  Size: 3.45 kB

@mtmorgan
Copy link
Collaborator

mtmorgan commented Oct 5, 2022

Can you try with

BiocManager::install("Bioconductor/AnVIL", ref = "allow-null-workflow-entities", force = TRUE)

@shbrief
Copy link
Contributor Author

shbrief commented Oct 6, 2022

It's taking NULL asentityName and entityType now. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants