Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install only from BiocManager, update vignette #13

Open
wants to merge 1 commit into
base: devel
Choose a base branch
from

Conversation

lwaldron
Copy link
Contributor

No description provided.

@lwaldron
Copy link
Contributor Author

Do you know why no automatic checks were performed on this pull request?

@seandavi
Copy link
Collaborator

seandavi commented Jul 14, 2020

Probably need to think a bit more about this one. The GH actions stuff is performed with the current checkout. That may not correspond to the master branch of the repository. Is there a way to have BiocManager::install use the local (checked out) package as the install source?

@lwaldron
Copy link
Contributor Author

I don't think BiocManager can do that. @LiNk-NY can you comment on how we should install the local package in this situation?

@csoneson
Copy link

Might combining it with something like this work, to just install (outdated) dependencies with BiocManager? https://github.com/csoneson/ExploreModelMatrix/actions/runs/166602031/workflow#L84-L90

@LiNk-NY
Copy link
Contributor

LiNk-NY commented Jul 15, 2020

Hi all, @seandavi @lwaldron @csoneson
I don't think that BiocManager has to do the install.
It can just do the installation / updating of the dependencies as Charlotte said.
The package is installed further down the line in the Check step by rcmdcheck(".").

Edit: I forgot about the Dockerfile which does the installation. I need to investigate more to see how that comes into play and if it needs to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants