Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imbalanced covariates metrics and sklearn scorer wrapper #59

Merged
merged 5 commits into from
Jun 22, 2023

Conversation

ehudkr
Copy link
Collaborator

@ehudkr ehudkr commented Jun 22, 2023

Some additions and fixes:

  1. Add a weight-model metric counting the number (or fraction) of imbalanced features.
  2. Add a propensity-model scorer wrapping arbitrary scikit-learn metrics.
    This is added to contrib because the implementation does not align with current (sklearn-inspired) scorer implementation, as the sklearn scorer can be arbitrary and passed into the scorer class - required user to initialize the scorer as opposed to already-initialized regular scorer.
  3. Add **kwargs to the metrics signature, this will align their signature which will allow more generalized calls (more metric-agnostic calls).
  4. Add name for the time-variable in the survival NHEFS loader which went missing in the last refactor.

ehudkr added 5 commits June 22, 2023 12:07
Signed-off-by: Ehud-Karavani <ehud.karavani@ibm.com>
Signed-off-by: Ehud-Karavani <ehud.karavani@ibm.com>
Signed-off-by: Ehud-Karavani <ehud.karavani@ibm.com>
Signed-off-by: Ehud-Karavani <ehud.karavani@ibm.com>
Signed-off-by: Ehud-Karavani <ehud.karavani@ibm.com>
@ehudkr ehudkr merged commit a494221 into master Jun 22, 2023
@ehudkr ehudkr deleted the more-metrics branch June 22, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant