Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add **kwargs to covariate_imbalance_count_error #64

Merged
merged 3 commits into from
Oct 25, 2023
Merged

Add **kwargs to covariate_imbalance_count_error #64

merged 3 commits into from
Oct 25, 2023

Conversation

mmdanziger
Copy link
Contributor

Other error functions use **kwargs to maintain flexibility about calling API, this function was missing it.

mmdanziger and others added 3 commits October 24, 2023 16:35
@mmdanziger
Add **kwargs to covariate_imbalance_count_error
76c2bef 
Other error functions use **kwargs to maintain flexibility about calling API, this function was missing it.
@ehudkr
Add test for non-existing kwargs in count_imbalance metric
a9b5313 
Signed-off-by: Ehud-Karavani <ehud.karavani@ibm.com>
@ehudkr
Bump CodeClimate Github Action version to v5.0.0
1850517 
Signed-off-by: Ehud-Karavani <ehud.karavani@ibm.com>
ehudkr
ehudkr approved these changes Oct 25, 2023
View reviewed changes
Copy link
Collaborator

@ehudkr ehudkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.
Tried to fix the CodeClimate issue while at it but weren't successful.
Test pass, though. I'll try better later

@ehudkr ehudkr merged commit f871ac1 into BiomedSciAI:master Oct 25, 2023
1 of 4 checks passed
@mmdanziger mmdanziger deleted the patch-1 branch October 25, 2023 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehudkr ehudkr ehudkr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmdanziger @ehudkr