Update pandas>2 and networkx>3 for simulation module and some unit tests #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--------- Signed-off-by: Diane Vincent <diane.vincent78@gmail.com>
|
|
It seems forked-branch pull-request do not initiate CodeClimate properly, causing the entire PR look like it failed. The problem is that the forked PR doesn't have access to the upstream's secret, so CodeClimate doesn't have its token: https://github.com/BiomedSciAI/causallib/actions/runs/10010566187/job/27714442507?pr=71#step:8:17 Before I contemplate whether to make that not-really-secret secret a hardcoded token instead, I want to test whether making a dummy commit by a permitted account could make it run properly. Signed-off-by: Ehud-Karavani <ehud.karavani@ibm.com>
Forked PRs have no access to secrets, so uploading a coverage report to Code Climate can fail as no token will be provided. To avoid that failing the entire workflow, try to make that step optional and see what happens on Github Actions. Signed-off-by: Ehud-Karavani <ehud.karavani@ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update causallib simulation module (CausalSimulator3) to allow newer version of its dependencies: pandas>2 and networkx>3
Unit tests to test different link types: affine, poly, exp and log
Unit test for effect modifier in marginal structural model: check that covariates have the same linking_coefs for the potential outcomes and effect modifiers have different ones