Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

training readout does not work #19

Open
jackklpan opened this issue May 30, 2020 · 3 comments
Open

training readout does not work #19

jackklpan opened this issue May 30, 2020 · 3 comments

Comments

@jackklpan
Copy link

jackklpan commented May 30, 2020

Hi,

I meet two problems when training the readout network.

return self._do_restrict_information(x, alpha)

does not work now, since
def _do_restrict_information(self, x):

accepts one argument now.
(Currently, I checkout to the previous commit)

alpha.clamp(-self._alpha_bound, self._alpha_bound)

should be alpha = alpha.clamp(....
(The alpha become -infinite)

Could you check the current code can train the readout network?
Thanks!

karl-schulz added a commit to karl-schulz/IBA that referenced this issue May 31, 2020
karl-schulz added a commit that referenced this issue May 31, 2020
Improved stability of readout training, worked on issue #19, smaller doc fixes
@karl-schulz
Copy link
Collaborator

Hi @jackklpan !

You are right, there were some issues I hope to have resolved with the latest pull request #21 . We will add a test for the readout IBA so this doesn't happen again.

Regarding the stability of the training, good spot! We also improved a minimal std in the normalization step to prevent divsion by very small numbers.

Please check if this solves your issues, we will do the same. We are happy to hear about your results.

Thanks for your contribution!

@jackklpan
Copy link
Author

Thanks! I will try to train again.

@voa18105
Copy link

voa18105 commented Jun 3, 2020

Hello! Actually, there is a same issue with "per sample" - no alpha given

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants