Expose methods #39
Merged
Expose methods #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onst information to b2BodyDef bindings (for what it's worth). correct b2Body#GetLinearVelocity return type to be const-ref.
… clashed with JSContactListener, and the performance problem it was designed to solve (eliminating WASM->JS calls) is not an issue nowadays (https://hacks.mozilla.org/2018/10/calls-between-javascript-and-webassembly-are-finally-fast-%F0%9F%8E%89/)
…m. bind methods. use Array.from to get access to forEach method. prove LeakMitigator in integration test. catch the leaked NULL. drop source-map-support. update ts-node. ignore WASM maps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #38
Closes #36
Closes #35
Exposed:
b2BodyDef#enabledattribute (resolves 'enabled' attribute is missing from b2BodyDef #38)b2Body#ApplyLinearImpulseToCentermethod (resolves Functionb2Body::ApplyLinearImpulseToCentermissing #36)Added
LeakMitigatorfor freeing retained references from Emscripten's JS object caches.Deleted (unreachable) type
JSContactListenerWithoutSolveCallbacks(resolves #35); the performance problem it was designed to solve (eliminating WASM->JS calls) is not a problem nowadays. PreferJSContactListener.