Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add linux support #3

Merged
merged 1 commit into from
Jul 11, 2018
Merged

add linux support #3

merged 1 commit into from
Jul 11, 2018

Conversation

charliewolf
Copy link
Contributor

Here are the changes I made to compile this for linux

@Birch-san
Copy link
Owner

Thanks!
How does it find libfluidsynth? Does the user need to pass in LDFLAGS=/usr/local/lib or something?

Presumably this makes a non-portable release? Since it dynamically links to libfluidsynth, which presumably has many dynamic dependencies, and there's no bundling step, nor setting of rpaths, nor relinking.

I think that's fine if it's distributed via apt-get or similar, since then you can ensure that dependencies are already installed on the target machine.

But either way, this should be good for building & running locally.

@Birch-san Birch-san merged commit db7d600 into Birch-san:master Jul 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants