chore(core): dvm to evm - allow users to send more than the expected amt #1243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for quantumbridge ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
lykalabrada
force-pushed
the
lyka/update-dvm-to-evm-balance-check
branch
from
9f8e5f6 to
f1b0134
Compare
lykalabrada
requested review from
fullstackninja864 and
pierregee
as code owners
* chore(e2e): added testcases for more than required fun transfer * added e2e for DFI verification * added DFI test case to check less than expected amount
pierregee
approved these changes
Dec 6, 2023
|
This pull request is stale because it has been open for 90 days without any activity. Please remove the stale label or this will be closed in 14 days. |
fullstackninja864
temporarily deployed
to
AWS ECR
GitHub Actions
Inactive
fullstackninja864
temporarily deployed
to
AWS ECR
GitHub Actions
Inactive
|
This pull request is stale because it has been open for 90 days without any activity. Please remove the stale label or this will be closed in 14 days. |
fullstackninja864
temporarily deployed
to
AWS ECR
GitHub Actions
Inactive
fullstackninja864
temporarily deployed
to
AWS ECR
GitHub Actions
Inactive
github-actions
bot
removed
the
stale
|
This pull request is stale because it has been open for 90 days without any activity. Please remove the stale label or this will be closed in 14 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Currently, we are receiving a lot of refund requests due to Error Code 3 - Balance Not Matched. And the difference in the amount is very minute, eg.: Expected amount is 1.001, but user sent 1.002
So to reduce the number of refund requests, we will modify the condition and allow users to send more funds than expected.
Which issue(s) does this PR fixes?:
Fixes #
Additional comments?:
Developer Checklist: