Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sklearn version requirement #24

Closed
dan-bishopfox opened this issue Apr 10, 2019 · 4 comments
Closed

Add sklearn version requirement #24

dan-bishopfox opened this issue Apr 10, 2019 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@dan-bishopfox
Copy link
Member

We're using a specific feature of sklearn that's fairly new. (March 2019) So let's add 0.20.0 of scikit-learn as a requirement.
@dan-bishopfox dan-bishopfox added the enhancement New feature or request label Apr 10, 2019
@dan-bishopfox
Copy link
Member Author

The current ML AMI doesn't use that version of sklearn, but it was pretty painless to update with conda:

conda install scikit-learn=0.20

@dan-bishopfox dan-bishopfox added the good first issue Good for newcomers label Apr 15, 2019
@the-bumble
Copy link
Contributor

@dan-bishopfox is this resolved? Should we create a separate issue to have a conda-based build script, or a Docker image to ensure we have smoother transitions to the Amazon ML AMI?

@dan-bishopfox
Copy link
Member Author

It's not fixed at the moment, no.

And yea, a conda-based script/instructions would be good. It's not obvious and actually quite a pain.

@the-bumble
Copy link
Contributor

@dan-bishopfox This should be fixed by the build system added in #42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@the-bumble @dan-bishopfox