Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-org'd project, build-system, and added tests #42

Merged
merged 1 commit into from
May 21, 2019
Merged

Conversation

the-bumble
Copy link
Contributor

Added a test ecosystem and made some sweet changes to the build system! See the diff on the README for details.

We can now build in python venvs, and conda venvs. The entire project can be installed on AWS ML AMI in one command now: make conda

Also, added test cases and corrected project structure, accordingly. This should address #31. If we want to add more unit tests we should create detailed tickets accordingly. I started us off by writing a series of tests against predict. Currently the oldlooking classifier doesn't appear to be working, so it's working already :). see make test

@the-bumble the-bumble requested a review from dan-bishopfox May 17, 2019 19:34
This was referenced May 17, 2019
@dan-bishopfox
Copy link
Member

I tried this on my EC2 machine, installed via conda (make conda) but the GPU doesn't seem to work.

Like, it functionally works, but it's clearly only engaging the CPU. (takes 40 minutes to train one epoch as opposed to 2 minutes)

@dan-bishopfox
Copy link
Member

Ah, looks like you need to just install tensorflow-gpu not tensorflow

@the-bumble
Copy link
Contributor Author

Do you want to merge it and make that change? Or should I modify it? Is that in the setup.py?

@dan-bishopfox
Copy link
Member

I can make the change, it's literally 4 characters to fix :)

@dan-bishopfox dan-bishopfox merged commit 3fb5a38 into master May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants