Re-org'd project, build-system, and added tests #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tried this on my EC2 machine, installed via conda (make conda) but the GPU doesn't seem to work. Like, it functionally works, but it's clearly only engaging the CPU. (takes 40 minutes to train one epoch as opposed to 2 minutes) |
|
Ah, looks like you need to just install tensorflow-gpu not tensorflow |
|
Do you want to merge it and make that change? Or should I modify it? Is that in the setup.py? |
|
I can make the change, it's literally 4 characters to fix :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a test ecosystem and made some sweet changes to the build system! See the diff on the README for details.
We can now build in python venvs, and conda venvs. The entire project can be installed on AWS ML AMI in one command now:
make condaAlso, added test cases and corrected project structure, accordingly. This should address #31. If we want to add more unit tests we should create detailed tickets accordingly. I started us off by writing a series of tests against
predict. Currently the oldlooking classifier doesn't appear to be working, so it's working already :). seemake test