Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CLI changes #1537

Merged
merged 19 commits into from
Jan 4, 2024
Merged

Fix CLI changes #1537

merged 19 commits into from
Jan 4, 2024

Conversation

rkervella
Copy link
Member

Merges #1353 and fixes merge conflicts.

maxlandon and others added 18 commits June 7, 2023 21:44
@maxlandon
Fix some newlines printed or not
44ceccf
@maxlandon
Add a flags package, in which we store some command utility functions to
bce0c8d 
bind flags, completions, apply command filters, etc.
@maxlandon
Start splitting commands declarations
ec88f9b
@maxlandon
Finish splitting server commands in their files
f370e96
@maxlandon
Split sliver commands in their files
e23f040
@maxlandon
Finish splits. Compiles
2da61c1
@maxlandon
Add many missing completers
51473ec
@maxlandon
Merge remote-tracking branch 'BishopFox/master' into beacon-commands
ba34df3
@maxlandon
Fix beacon compile flags + debug level for client asciicast
47a280c
@maxlandon
Fmt
163c11b
@maxlandon
Filter portfwd/socks commands out of beacons
be65f1c
@maxlandon
Simplify binding commands with groups
d5c1daa
@maxlandon
Rename SliverConsoleClient to SliverClient
12065fd
@rkervella
Merge branch 'master' into beacon-commands
1da52a3
@rkervella
Merge branch 'master' into beacon-commands
46a3385
@moloch--
Merge branch 'master' into beacon-commands
a79b397
@rkervella
Merge branch 'beacon-commands' of https://github.com/maxlandon/sliver …
eecaeab 
…into maxlandon-beacon-commands
@rkervella
Fix last merge issues
2ad8aa4
@rkervella rkervella requested a review from a team as a code owner January 3, 2024 00:18
@rkervella rkervella mentioned this pull request Jan 3, 2024
Closed
@RafBishopFox RafBishopFox mentioned this pull request Jan 3, 2024
Merged
@rkervella rkervella mentioned this pull request Jan 3, 2024
Closed
RafBishopFox
RafBishopFox approved these changes Jan 4, 2024
View reviewed changes
Copy link
Collaborator

@RafBishopFox RafBishopFox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this a couple of days ago, and things seem to work. Issues I saw before (like hanging after killing implants) seem to be gone now.

@rkervella rkervella merged commit bdd8390 into master Jan 4, 2024
5 checks passed
@RafBishopFox RafBishopFox mentioned this pull request Jan 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RafBishopFox RafBishopFox RafBishopFox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rkervella @RafBishopFox @maxlandon @moloch--