Updated Dockerfile to support multi-architecture builds #1589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c installations. **Added:** - Multi-arch build instructions for production and unit testing stages. - Conditional installation of `gcc-multilib` based on architecture in `test` and `production` stages. **Changed:** - Removed explicit platform specification in `FROM` directives to support multi-architecture builds. - Refactored installation commands to include architecture-specific conditions. - Updated `production` stage to create additional directories in the `sliver` user's home directory.
Signed-off-by: Jayson Grace <jayson.e.grace@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to run sliver in my ARM-based k8s cluster and quickly determined that
some changes would need to be made to facilitate that. This PR contains
the changes that were necessary to build an ARM64-based sliver container image. It can easily support additional architectures via the
docker buildx buildcommand (seeDockerfile).Added:
gcc-multilibbased on architecture intestandproductionstages.Changed:
FROMdirectives to support multi-architecture builds.productionstage to create additional directories in thesliveruser's home directory.