Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(CLI) Fix cli test, update print list #1113

Merged
merged 19 commits into from
Feb 8, 2024
Merged

(CLI) Fix cli test, update print list #1113

merged 19 commits into from
Feb 8, 2024

Conversation

nick-bisonai
Copy link
Collaborator

@nick-bisonai nick-bisonai commented Feb 5, 2024 •
edited
Loading

Description

  • update misconfigurations.
  • fix test errors,
  • modify reporter list, listener list, delegeter reporterList to make single api call for feed names
    Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.

Deployment

  • Should publish npm package
  • Should publish Docker image

@nick-bisonai nick-bisonai requested review from martinkersner, KelvinThai and a user February 5, 2024 08:02
@nick-bisonai nick-bisonai self-assigned this Feb 5, 2024
@nick-bisonai nick-bisonai marked this pull request as ready for review February 6, 2024 07:32
@nick-bisonai nick-bisonai force-pushed the fix/cli-fix-path branch 2 times, most recently from 24973d7 to ed3b464 Compare February 6, 2024 07:35
@nick-bisonai nick-bisonai marked this pull request as draft February 6, 2024 13:14
@nick-bisonai nick-bisonai force-pushed the fix/cli-fix-path branch 2 times, most recently from ac2d48b to 400a2b8 Compare February 7, 2024 09:52
@nick-bisonai nick-bisonai changed the title (CLI) Update path for aggregator name (CLI) Fix cli test, update print list Feb 7, 2024
@nick-bisonai nick-bisonai marked this pull request as ready for review February 7, 2024 11:28
martinkersner
martinkersner approved these changes Feb 8, 2024
View reviewed changes
Copy link
Member

@martinkersner martinkersner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

cli/src/vrf.ts Outdated Show resolved Hide resolved
cli/src/reporter.ts
@@ -149,20 +149,28 @@ export function listHandler(print?: boolean) {

try {
const result = (await axios.get(REPORTER_ENDPOINT, { data: { chain, service } }))?.data

const printResult: any[] = []
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this solution much more than before! 🚀

@nick-bisonai nick-bisonai merged commit ce676ce into master Feb 8, 2024
2 checks passed
@nick-bisonai nick-bisonai deleted the fix/cli-fix-path branch February 8, 2024 05:05
This was referenced Feb 8, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinkersner martinkersner martinkersner approved these changes

@KelvinThai KelvinThai Awaiting requested review from KelvinThai

Assignees

@nick-bisonai nick-bisonai

Labels
cli
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nick-bisonai @martinkersner