Remove onchain aggregator related codes from /core and /cli
#1808
Conversation
|
Important Review skippedReview was skipped due to path filters Files ignored due to path filters (1)
You can disable this status message by setting the WalkthroughWalkthroughThe changes streamline the project's code by removing outdated or unnecessary modules related to Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
core/package.jsonis excluded by!**/*.json
Files selected for processing (3)
- cli/src/index.ts (3 hunks)
- cli/src/settings.ts (1 hunks)
- cli/src/utils.ts (1 hunks)
Files skipped from review due to trivial changes (2)
- cli/src/index.ts
- cli/src/utils.ts
Additional comments not posted (6)
cli/src/settings.ts (6)
5-5: LGTM!The default API URL is correctly set based on the
NODE_ENVenvironment variable.
11-11: LGTM!The default delegator URL is correctly set based on the
NODE_ENVenvironment variable.
11-11: LGTM!The default listener host has been correctly updated to reflect the new service name
vrf-listener.
16-16: LGTM!The default worker host has been correctly updated to reflect the new service name
vrf-worker.
21-21: LGTM!The default reporter host has been correctly updated to reflect the new service name
vrf-reporter.
26-28: LGTM!The new environment variables
ORAKL_NETWORK_API_URLandORAKL_NETWORK_DELEGATOR_URLare correctly introduced to allow for configurable URLs.
|
a few points:
|
|
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (1)
core/src/listener/types.ts (1)
References to
IDataFeedListenerWorkerstill exist in the codebase.The following files contain references to
IDataFeedListenerWorker:
core/src/types.tscore/src/listener/types.tscore/src/listener/data-feed-L2.tscore/src/worker/data-feed-L2.tsPlease ensure all references are removed if
IDataFeedListenerWorkeris intended to be deprecated.Analysis chain
Line range hint
1-52:
LGTM! But verify the removal ofIDataFeedListenerWorkerusage in the codebase.The code changes are approved.
However, ensure that all references to
IDataFeedListenerWorkerhave been removed from the codebase.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the removal of `IDataFeedListenerWorker` usage in the codebase. # Test: Search for the `IDataFeedListenerWorker` references. Expect: No occurrences. rg --type python -A 5 $'IDataFeedListenerWorker'Length of output: 78
Script:
#!/bin/bash # Description: Verify the removal of `IDataFeedListenerWorker` usage in the codebase. # Test: Search for the `IDataFeedListenerWorker` references. Expect: No occurrences. rg --type typescript -A 5 $'IDataFeedListenerWorker'Length of output: 86
Script:
#!/bin/bash # Description: Verify the removal of `IDataFeedListenerWorker` usage in the codebase. # Test: Search for the `IDataFeedListenerWorker` references. Expect: No occurrences. rg -A 5 $'IDataFeedListenerWorker'Length of output: 2701
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
cli/package.jsonis excluded by!**/*.json
Files selected for processing (8)
- core/src/errors.ts (1 hunks)
- core/src/listener/main.ts (2 hunks)
- core/src/listener/types.ts (2 hunks)
- core/src/main.ts (6 hunks)
- core/src/reporter/main.ts (2 hunks)
- core/src/types.ts (1 hunks)
- core/src/worker/api.ts (1 hunks)
- core/src/worker/main.ts (2 hunks)
Files skipped from review due to trivial changes (2)
- core/src/errors.ts
- core/src/reporter/main.ts
Additional comments not posted (7)
core/src/worker/main.ts (1)
Line range hint
1-36:
LGTM! But verify the removal ofdataFeedWorkerusage in the codebase.The code changes are approved.
However, ensure that all references to
dataFeedWorkerhave been removed from the codebase.Verification successful
Verification successful: All references to
dataFeedWorkerhave been removed from the codebase.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the removal of `dataFeedWorker` usage in the codebase. # Test: Search for the `dataFeedWorker` references. Expect: No occurrences. rg --type python -A 5 $'dataFeedWorker'Length of output: 69
Script:
#!/bin/bash # Description: Verify the removal of `dataFeedWorker` usage in the codebase. # Test: Search for the `dataFeedWorker` references. Expect: No occurrences. rg --type ts -A 5 $'dataFeedWorker'Length of output: 34
Script:
#!/bin/bash # Description: Verify the removal of `dataFeedWorker` usage in the codebase. # Test: Search for the `dataFeedWorker` references in all file types. Expect: No occurrences. rg -A 5 $'dataFeedWorker'Length of output: 24
core/src/listener/main.ts (1)
Line range hint
1-53:
LGTM! But verify the removal ofbuildDataFeedListenerusage in the codebase.The code changes are approved.
However, ensure that all references to
buildDataFeedListenerhave been removed from the codebase.Verification successful
Verification successful: All references to
buildDataFeedListenerhave been removed from the codebase.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the removal of `buildDataFeedListener` usage in the codebase. # Test: Search for the `buildDataFeedListener` references. Expect: No occurrences. rg --type python -A 5 $'buildDataFeedListener'Length of output: 76
Script:
#!/bin/bash # Description: Verify the removal of `buildDataFeedListener` usage in the codebase. # Test: Search for the `buildDataFeedListener` references. Expect: No occurrences. rg --type ts -A 5 $'buildDataFeedListener'Length of output: 41
core/src/worker/api.ts (1)
Line range hint
1-69:
LGTM! But verify the removal offetchDataFeedByAggregatorIdandgetAggregatorGivenAddressusage in the codebase.The code changes are approved.
However, ensure that all references to
fetchDataFeedByAggregatorIdandgetAggregatorGivenAddresshave been removed from the codebase.core/src/main.ts (3)
4-4: LGTM! Import changes align with the PR objective.The import statements have been updated to reflect the removal of
data-feedand the inclusion ofdata-feed-L2.Also applies to: 7-7, 10-10, 13-13, 16-16, 19-19, 22-22, 25-25
28-28: LGTM! Constant changes align with the PR objective.The constants have been updated to reflect the removal of
data-feedand the inclusion ofdata-feed-L2.Also applies to: 31-31, 34-34
37-37: LGTM! Function changes align with the PR objective.The functions have been updated to use the new constants reflecting the removal of
data-feedand the inclusion ofdata-feed-L2.Also applies to: 40-40, 43-43
core/src/types.ts (1)
Line range hint
70-70:
LGTM! Type definition changes align with the PR objective.The
IDataFeedListenerWorkerinterface has been removed and replaced withIDataFeedListenerWorkerL2.
Description
Removes onchain aggregator related codes
Type of change
Please delete options that are not relevant.
Checklist before requesting a review
Deployment