fix reporter tests failing

[Intizar-T]

Description

Please include a summary of the changes and the related issue.
Please also include relevant motivation and context.
List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

Checklist before requesting a review

• I have performed a self-review of my code.
• If it is a core feature, I have added thorough tests.

Deployment

• Should publish npm package
• Should publish Docker image

[coderabbitai]

Walkthrough

Walkthrough

The changes involve updates to a GitHub Actions workflow and modifications to the App struct in the codebase. The WebSocket URL for Klaytn has been redirected from the Cypress network to the Baobab network, and the Ethereum WebSocket URL has been removed. Additionally, method names in the App struct have been capitalized to signify their export status. Test logic has been simplified with direct invocations and changes in connection lifecycle management.

Changes

Files	Change Summary
.github/workflows/reporter.test.yaml	Updated KAIA_WEBSOCKET_URL to point to Baobab network; removed ETH_WEBSOCKET_URL.
node/pkg/reporter/app.go, node/pkg/reporter/app_test.go	Renamed handleWsMessage to HandleWsMessage for export; simplified TestWsDataHandling by removing initial error handling and changing test setup for WebSocket connections.

Sequence Diagram(s)

sequenceDiagram
    participant App
    participant WebSocketHelper

    App->>WebSocketHelper: Run(ctx, HandleWsMessage)
    WebSocketHelper->>App: Handle WebSocket Messages
    App->>Client: Process Messages
    Client-->>App: Return Results

Loading

🐰 "With hops and jumps, the code's anew,
The WebSocket path now shines bright and true.
From Cypress to Baobab, the change takes flight,
In tests we leap, our logic feels light.
Methods now stand tall, a joyful sight,
Celebrate these changes, all feels just right!" 🥕

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[nick-bisonai]

lgtm!

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 5caa4ed and c8996ae.

Files selected for processing (3)

• .github/workflows/reporter.test.yaml (1 hunks)
• node/pkg/reporter/app.go (2 hunks)
• node/pkg/reporter/app_test.go (2 hunks)

Additional comments not posted (4)

node/pkg/reporter/app_test.go (1)

42-42: Streamline WebSocket handling in tests.

The direct invocation of app.WsHelper.Run(ctx, app.HandleWsMessage) in a goroutine simplifies the test logic by integrating the reporter start functionality within the WebSocket helper. Ensure that this change does not affect the test's reliability.

Consider verifying the test results to ensure the new approach handles WebSocket messages as expected. If issues arise, review the WebSocket helper's implementation for connection management.

.github/workflows/reporter.test.yaml (1)

79-79: Update WebSocket URL for Klaytn network.

The KAIA_WEBSOCKET_URL has been updated to use the Baobab network, which may affect how the application interacts with the Klaytn blockchain. Ensure that this change aligns with the project's requirements and that all dependent systems are updated accordingly.

Consider verifying the application's behavior with the new WebSocket URL to ensure compatibility and functionality.

node/pkg/reporter/app.go (2)

122-122: Capitalize method name for export.

The method handleWsMessage has been renamed to HandleWsMessage to indicate its export status. Ensure that this change is reflected in all parts of the codebase where the method is used.

Verify that all references to handleWsMessage have been updated to HandleWsMessage to prevent any potential issues with method accessibility.

---

Line range hint 155-160: Ensure proper error handling in HandleWsMessage.

The method processes WebSocket messages and stores data in LatestDataMap. Ensure that error handling is robust and that any potential issues with data processing are logged and managed appropriately.

Review the error handling logic in ProcessDalWsRawData to ensure it aligns with the application's error management strategy.