fix cppcheck failure (#1)

* fix cppcheck failure * fix build script not running and credentials could not be fetched * restore configure-aws-credentials to v2 * add execute permission for shell scripts * remove bash for mac build scripts * trigger all tests
Bit-Quill · Dec 7, 2023 · 657f5e6 · 657f5e6
1 parent 3e7055e
commit 657f5e6
Show file tree

Hide file tree

Showing 21 changed files with 29 additions and 3 deletions.
diff --git a/amazon-timestream-odbc-driver/build_linux_debug32_deb.sh b/amazon-timestream-odbc-driver/build_linux_debug32_deb.sh
@@ -1,3 +1,5 @@
+#!/bin/bash
+
 # Copyright <2022> Amazon.com, Inc. or its affiliates. All Rights Reserved.
 #
 # Licensed under the Apache License, Version 2.0 (the "License").

diff --git a/amazon-timestream-odbc-driver/build_linux_debug32_rpm.sh b/amazon-timestream-odbc-driver/build_linux_debug32_rpm.sh
@@ -1,3 +1,5 @@
+#!/bin/bash
+
 # Copyright <2022> Amazon.com, Inc. or its affiliates. All Rights Reserved.
 #
 # Licensed under the Apache License, Version 2.0 (the "License").

diff --git a/amazon-timestream-odbc-driver/build_linux_debug64_deb.sh b/amazon-timestream-odbc-driver/build_linux_debug64_deb.sh
@@ -1,3 +1,5 @@
+#!/bin/bash
+
 # Copyright <2022> Amazon.com, Inc. or its affiliates. All Rights Reserved.
 #
 # Licensed under the Apache License, Version 2.0 (the "License").

diff --git a/amazon-timestream-odbc-driver/build_linux_debug64_rpm.sh b/amazon-timestream-odbc-driver/build_linux_debug64_rpm.sh
@@ -1,3 +1,5 @@
+#!/bin/bash
+
 # Copyright <2022> Amazon.com, Inc. or its affiliates. All Rights Reserved.
 #
 # Licensed under the Apache License, Version 2.0 (the "License").

diff --git a/amazon-timestream-odbc-driver/build_linux_release32_deb.sh b/amazon-timestream-odbc-driver/build_linux_release32_deb.sh
@@ -1,3 +1,5 @@
+#!/bin/bash
+
 # Copyright <2022> Amazon.com, Inc. or its affiliates. All Rights Reserved.
 #
 # Licensed under the Apache License, Version 2.0 (the "License").

diff --git a/amazon-timestream-odbc-driver/build_linux_release32_rpm.sh b/amazon-timestream-odbc-driver/build_linux_release32_rpm.sh
@@ -1,3 +1,5 @@
+#!/bin/bash
+
 # Copyright <2022> Amazon.com, Inc. or its affiliates. All Rights Reserved.
 #
 # Licensed under the Apache License, Version 2.0 (the "License").

diff --git a/amazon-timestream-odbc-driver/build_linux_release64_deb.sh b/amazon-timestream-odbc-driver/build_linux_release64_deb.sh
@@ -1,3 +1,5 @@
+#!/bin/bash
+
 # Copyright <2022> Amazon.com, Inc. or its affiliates. All Rights Reserved.
 #
 # Licensed under the Apache License, Version 2.0 (the "License").

diff --git a/amazon-timestream-odbc-driver/build_linux_release64_rpm.sh b/amazon-timestream-odbc-driver/build_linux_release64_rpm.sh
@@ -1,3 +1,5 @@
+#!/bin/bash
+
 # Copyright <2022> Amazon.com, Inc. or its affiliates. All Rights Reserved.
 #
 # Licensed under the Apache License, Version 2.0 (the "License").

diff --git a/amazon-timestream-odbc-driver/build_mac_debug64.sh b/amazon-timestream-odbc-driver/build_mac_debug64.sh
@@ -53,4 +53,3 @@ if [ $RET_CODE -ne 0 ]; then
 fi
 
 cd ..
-
diff --git a/amazon-timestream-odbc-driver/build_mac_release64.sh b/amazon-timestream-odbc-driver/build_mac_release64.sh
diff --git a/amazon-timestream-odbc-driver/build_performance_linux64.sh b/amazon-timestream-odbc-driver/build_performance_linux64.sh
diff --git a/amazon-timestream-odbc-driver/build_performance_mac64.sh b/amazon-timestream-odbc-driver/build_performance_mac64.sh
diff --git a/amazon-timestream-odbc-driver/run_cppcheck.ps1 b/amazon-timestream-odbc-driver/run_cppcheck.ps1
@@ -16,7 +16,7 @@
 #  --force: force checks all define combinations (default max is 12)
 #  --suppress=objectIndex: seemingly false-positive
 
-cppcheck --force --library=boost --library=documentdb .\src\ 2>  .\cppcheck-results.log
+cppcheck --force --library=boost --library=timestream .\src\ 2>  .\cppcheck-results.log
 If ((Get-Content "cppcheck-results.log") -eq $Null) {
   exit 0
 }

diff --git a/amazon-timestream-odbc-driver/run_cppcheck.sh b/amazon-timestream-odbc-driver/run_cppcheck.sh
@@ -17,7 +17,7 @@ RESULTS_FILE=cppcheck-results.log
 
 # --force: force checks all define combinations (default max is 12)
 # -iaws-sdk-cpp: avoid checking AWS C++ SDK source files in our repo
-cppcheck --force --library=boost --library=documentdb -UWIN32 ./src/ 2>  ${RESULTS_FILE}
+cppcheck --force --library=boost --library=timestream -UWIN32 ./src/ 2>  ${RESULTS_FILE}
 
 if [ -s ${RESULTS_FILE} ]; then
     echo "!! Cppcheck errors found! Check ${RESULTS_FILE} for details."

diff --git a/amazon-timestream-odbc-driver/run_test_runner.sh b/amazon-timestream-odbc-driver/run_test_runner.sh
diff --git a/amazon-timestream-odbc-driver/scripts/build_linux.sh b/amazon-timestream-odbc-driver/scripts/build_linux.sh
diff --git a/amazon-timestream-odbc-driver/scripts/env_variables_check.sh b/amazon-timestream-odbc-driver/scripts/env_variables_check.sh
diff --git a/amazon-timestream-odbc-driver/scripts/postinst_unix.sh b/amazon-timestream-odbc-driver/scripts/postinst_unix.sh
diff --git a/amazon-timestream-odbc-driver/scripts/register_driver_unix.sh b/amazon-timestream-odbc-driver/scripts/register_driver_unix.sh
diff --git a/amazon-timestream-odbc-driver/scripts/unix_check_changes.sh b/amazon-timestream-odbc-driver/scripts/unix_check_changes.sh
diff --git a/amazon-timestream-odbc-driver/timestream.cfg b/amazon-timestream-odbc-driver/timestream.cfg
@@ -0,0 +1,11 @@
+<?xml version="1.0"?>
+<def format="2">
+  <!-- Boost Library Configuration -->
+  <!-- Documentation: https://www.boost.org/doc/libs/ -->
+  <!-- ########## Boost defines / macros ########## -->
+  <define name="IGNITE_BINARY_TYPE_START(T)" value=""/>
+  <define name="IGNITE_BINARY_GET_TYPE_NAME_AS_IS(typeName)" value=""/>
+  <define name="IGNITE_BINARY_GET_FIELD_ID_AS_HASH" value=""/>
+  <define name="IGNITE_BINARY_IS_NULL_FALSE(T)" value=""/>
+  <define name="IGNITE_BINARY_GET_NULL_DEFAULT_CTOR(T)" value=""/>  
+</def>
Original file line number	Diff line number	Diff line change
Expand Up		@@ -53,4 +53,3 @@ if [ $RET_CODE -ne 0 ]; then
		fi

		cd ..