Dev highlight in ppl #106
Closed
Dev highlight in ppl #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…roject. Signed-off-by: forestmvey <forestv@bitquilltech.com>
Signed-off-by: forestmvey <forestv@bitquilltech.com>
Signed-off-by: forestmvey <forestv@bitquilltech.com>
…quotes. Signed-off-by: forestmvey <forestv@bitquilltech.com>
Signed-off-by: forestmvey <forestv@bitquilltech.com>
Signed-off-by: forestmvey <forestv@bitquilltech.com>
MaxKsyunz
reviewed
Aug 17, 2022
| public LogicalPlan visitHighlight(Highlight node, AnalysisContext context) { | ||
| LogicalPlan child = node.getChild().get(0).accept(this, context); | ||
|
|
||
| if (!(((Alias)node.getExpression()).getDelegated() instanceof HighlightFunction)) { |
There was a problem hiding this comment.
Is this defensive check or is this situation possible?
Can the code be updated so that (Alias) casts and instanceof checks are not necessary?
There was a problem hiding this comment.
I don't believe this situation would be possible. I have removed the instanceof check and I wasn't able to figure out a way to update the code to not use casting.
integ-test/src/test/java/org/opensearch/sql/ppl/HighlightFunctionIT.java
Show resolved
Hide resolved
integ-test/src/test/java/org/opensearch/sql/ppl/HighlightFunctionIT.java
Show resolved
Hide resolved
integ-test/src/test/java/org/opensearch/sql/ppl/HighlightFunctionIT.java
Show resolved
Hide resolved
core/src/main/java/org/opensearch/sql/planner/physical/HighlightOperator.java
Show resolved
Hide resolved
core/src/main/java/org/opensearch/sql/planner/physical/HighlightOperator.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add PPL support for highlight in SQL plugin.
Issues Resolved
Issue: github-636
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.