Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DRAFT - Add support for highlight in PPL #107

Closed
wants to merge 29 commits into from
Closed

DRAFT - Add support for highlight in PPL #107

wants to merge 29 commits into from

Commits on Aug 17, 2022

  1. Bump Checkstyle version to latest (opensearch-project#767) 

    * Bump checkstyle version and fix violations

Signed-off-by: Chen Dai <daichen@amazon.com>

* Fix checkstyle violations in test code

Signed-off-by: Chen Dai <daichen@amazon.com>

Signed-off-by: Chen Dai <daichen@amazon.com>
    @dai-chen
    dai-chen authored Aug 17, 2022
    Configuration menu
    Copy the full SHA
    8103d9f View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2022

  1. Support highlight in Analyzer. 

    Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
    @forestmvey
    MaxKsyunz authored and forestmvey committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    f88f0f5 View commit details
    Browse the repository at this point in the history

  2. Add support for highlight in Analyzer 

    HighlightFunction is converted to LogicalHighlight logical plan.

Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
    @forestmvey
    MaxKsyunz authored and forestmvey committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    4f5766a View commit details
    Browse the repository at this point in the history

  3. Partial support for highlight in physical plan. 

    Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
    @forestmvey
    MaxKsyunz authored and forestmvey committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    8ccad68 View commit details
    Browse the repository at this point in the history

  4. Add HighlightOperator. 

    Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
    @forestmvey
    MaxKsyunz authored and forestmvey committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    2121bfb View commit details
    Browse the repository at this point in the history

  5. Highlight alpha complete. 

    Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
    @forestmvey
    MaxKsyunz authored and forestmvey committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    bcbb637 View commit details
    Browse the repository at this point in the history

  6. Initial implementation to upporting highlight('*') 

    Signed-off-by: forestmvey <forestv@bitquilltech.com>
    @forestmvey
    forestmvey committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    62926fb View commit details
    Browse the repository at this point in the history

  7. Add support for multiple highlight calls in select statement. 

    Signed-off-by: forestmvey <forestv@bitquilltech.com>
    @forestmvey
    forestmvey committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    8d519ba View commit details
    Browse the repository at this point in the history

  8. Removed OpenSearchLogicalIndexScan highlightFields and dependencies. … 

    …Improved test coverage and fixing checkstyle errors.

Signed-off-by: forestmvey <forestv@bitquilltech.com>
    @forestmvey
    forestmvey committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    efe0f39 View commit details
    Browse the repository at this point in the history

  9. Added HighlightExpressionTest 

    Signed-off-by: forestmvey <forestv@bitquilltech.com>
    @forestmvey
    forestmvey committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    182b022 View commit details
    Browse the repository at this point in the history

  10. Added javadocs, minor PR revisions, and fixed jacoco errors by improv… 

    …ing coverage for OpenSearchIndexScan

Signed-off-by: forestmvey <forestv@bitquilltech.com>
    @forestmvey
    forestmvey committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    82a2486 View commit details
    Browse the repository at this point in the history

  11. Code cleanup, adding parsing failure tests, and adding tests for high… 

    …light acceptance as a string literal as well as qualified name.

Signed-off-by: forestmvey <forestv@bitquilltech.com>
    @forestmvey
    forestmvey committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    57eb91b View commit details
    Browse the repository at this point in the history

  12. Removing HighlightOperator functionality and unnecessary visitHighlig… 

    …ht call in PhysicalPlanNodeVisitor..

Signed-off-by: forestmvey <forestv@bitquilltech.com>
    @forestmvey
    forestmvey committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    0cea4bb View commit details
    Browse the repository at this point in the history

  13. Initial commit. Resolving highlight as HighlightExpression with new p… 

    …roject.

Signed-off-by: forestmvey <forestv@bitquilltech.com>
    @forestmvey
    forestmvey committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    900be57 View commit details
    Browse the repository at this point in the history

  14. Initial successful naive implementation. 

    Signed-off-by: forestmvey <forestv@bitquilltech.com>
    @forestmvey
    forestmvey committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    b1f03aa View commit details
    Browse the repository at this point in the history

  15. Adding integration tests and updating function names. 

    Signed-off-by: forestmvey <forestv@bitquilltech.com>
    @forestmvey
    forestmvey committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    3a03e99 View commit details
    Browse the repository at this point in the history

  16. Add support highlight fields as no quotes, single quotes, and double … 

    …quotes.

Signed-off-by: forestmvey <forestv@bitquilltech.com>
    @forestmvey
    forestmvey committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    aafeb5f View commit details
    Browse the repository at this point in the history

  17. Remove not needed visitHighlight function. 

    Signed-off-by: forestmvey <forestv@bitquilltech.com>
    @forestmvey
    forestmvey committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    10ceafc View commit details
    Browse the repository at this point in the history

  18. Re-organize PPL parser grammar. 

    Signed-off-by: forestmvey <forestv@bitquilltech.com>
    @forestmvey
    forestmvey committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    0636ddb View commit details
    Browse the repository at this point in the history

  19. Fixing missed rebase error. 

    Signed-off-by: forestmvey <forestv@bitquilltech.com>
    @forestmvey
    forestmvey committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    7aa9c22 View commit details
    Browse the repository at this point in the history

  20. Formatting fixes for unnecessary changes with main branch. 

    Signed-off-by: forestmvey <forestv@bitquilltech.com>
    @forestmvey
    forestmvey committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    e74cfc5 View commit details
    Browse the repository at this point in the history

  21. Fixing AST tests for highlight. 

    Signed-off-by: forestmvey <forestv@bitquilltech.com>
    @forestmvey
    forestmvey committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    397d422 View commit details
    Browse the repository at this point in the history

  22. Fix failing checkstyle errors. 

    Signed-off-by: forestmvey <forestv@bitquilltech.com>
    @forestmvey
    forestmvey committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    8b0415d View commit details
    Browse the repository at this point in the history

  23. Add tests for HighlightOperator, PhysicalPlanNodeVisitor, and OpenSea… 

    …rchExecutionrotector. Refine HighlightOperator logic.

Signed-off-by: forestmvey <forestv@bitquilltech.com>
    @forestmvey
    forestmvey committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    fe56e40 View commit details
    Browse the repository at this point in the history

  24. Added LogicalHighlightTest and removed check for instance of Highligh… 

    …tFunction in Analyzer as this case should not be reachable.

Signed-off-by: forestmvey <forestv@bitquilltech.com>
    @forestmvey
    forestmvey committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    50139f2 View commit details
    Browse the repository at this point in the history

  25. Improving HighlightOperator test coverage and removing not used annot… 

    …ations from HighlightOperator.

Signed-off-by: forestmvey <forestv@bitquilltech.com>
    @forestmvey
    forestmvey committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    2d175f8 View commit details
    Browse the repository at this point in the history

  26. Fixed failing integration tests for highlight in PPL. 

    Signed-off-by: forestmvey <forestv@bitquilltech.com>
    @forestmvey
    forestmvey committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    89273eb View commit details
    Browse the repository at this point in the history

  27. Added EqualsAndHash annotation due to testing dependency. 

    Signed-off-by: forestmvey <forestv@bitquilltech.com>
    @forestmvey
    forestmvey committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    c656026 View commit details
    Browse the repository at this point in the history

  28. Adding documentation for highlight in ppl. 

    Signed-off-by: forestmvey <forestv@bitquilltech.com>
    @forestmvey
    forestmvey committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    9d554d0 View commit details
    Browse the repository at this point in the history