Draft Highlight Wildcard #111
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: forestmvey <forestv@bitquilltech.com>
Signed-off-by: forestmvey <forestv@bitquilltech.com>
Codecov Report
@@ Coverage Diff @@
## draft-highlight-wildcard #111 +/- ##
===============================================================
- Coverage 94.88% 62.76% -32.12%
===============================================================
Files 289 10 -279
Lines 7879 658 -7221
Branches 573 118 -455
===============================================================
- Hits 7476 413 -7063
+ Misses 349 192 -157
+ Partials 54 53 -1
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
MaxKsyunz
reviewed
Aug 30, 2022
| @@ -304,7 +304,7 @@ functionCall | |||
| ; | |||
|
|
|||
| highlightFunction | |||
| : HIGHLIGHT LR_BRACKET relevanceField RR_BRACKET | |||
| : HIGHLIGHT LR_BRACKET relevanceField RR_BRACKET (DOT qualifiedName)* | |||
There was a problem hiding this comment.
Querying complex values should be independent of highlight -- let's not tackle it as part of this PR.
Looks like SQL plugin does not support querying complex values returned by an expression and highlight('*') is an expression.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add wildcard support in both SQL and PPL. This draft PR addresses using the
. DOTnotation to access nested fields of an expression.Issues Resolved
Issue: 636
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.