Fix Relevance Fields Permissive When Fields are Missing.

[forestmvey]

Signed-off-by: forestmvey forestv@bitquilltech.com

Description

Relevance functions that query a field should act similar to how a SELECT query works. If a field is queried that does not exist, a SemanticCheckException should be thrown.

Example Queryies

SELECT * FROM stackexchange_beer WHERE query_string([invalid], 'beer');

{'reason': 'Invalid SQL query', 'details': "can't resolve Symbol(namespace=FIELD_NAME, name=invalid) in type env", 'type': 'SemanticCheckException'}

SELECT * FROM stackexchange_beer WHERE match(invalid, 'beer');

{'reason': 'Invalid SQL query', 'details': "can't resolve Symbol(namespace=FIELD_NAME, name=invalid) in type env", 'type': 'SemanticCheckException'}

Issues Resolved

Issue: 613

Check List

• New functionality includes testing.
  • All tests pass, including unit test, integration test and doctest
• New functionality has been documented.
  • New functionality has javadoc added
  • New functionality has user manual doc added
• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (integ-fix-permissive-relevance-fields@03f30e3). Click here to learn what that means.
The diff coverage is n/a.

@@                           Coverage Diff                            @@
##             integ-fix-permissive-relevance-fields     #158   +/-   ##
========================================================================
  Coverage                                         ?   98.27%           
  Complexity                                       ?     3366           
========================================================================
  Files                                            ?      327           
  Lines                                            ?     8486           
  Branches                                         ?      556           
========================================================================
  Hits                                             ?     8340           
  Misses                                           ?      142           
  Partials                                         ?        4           

Flag	Coverage Δ
sql-engine	98.27% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[Yury-Fridlyand]

Should we have integration tests?

[forestmvey]

Should we have integration tests?

I have added some IT tests to cover invalid fields in my latest commit.

[MaxKsyunz]

LGTM.

In the upstream PR, could you reword the title? It is used to generate release notes like these.

Something like "validate field and fields parameters in relevance search functions" would work.