Add GitHub workflow to pack BI connectors #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…The PBI connector is being built twice with different names accroding to the Amazon's request. Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com>
Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com>
Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com>
Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com>
Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com>
Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com>
Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com>
Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com>
Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com>
…ore than in filename to make PBI distuingish them Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com>
Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com>
Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com>
For all connectors added check for successful packing before publishing Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com>
Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com>
Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com>
ghost
approved these changes
Dec 17, 2021
kylepbit
reviewed
Dec 17, 2021
| @@ -19,7 +19,7 @@ SqlOdbcPBIConnectorType = type function ( | |||
| ]) | |||
| ) | |||
| as table meta [ | |||
| Documentation.Name = "OpenSearch" | |||
| Documentation.Name = "OpenSearch Project" | |||
There was a problem hiding this comment.
Where are these changes here, they seem unrelated to the GitHub flows?
There was a problem hiding this comment.
According to Amazon's request we should build 2 connectors: one for OpenSearch Project and the second one - for Amazon OpenSearch Service. OpenSearch is not a valid name.
kylepbit
reviewed
Dec 17, 2021
.github/workflows/bi-connectors.yml
Outdated
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v1 | ||
| - name: Pack Tableau ODBC connector |
There was a problem hiding this comment.
Why do we pack both ODBC and JDBC? I thought we were only going to use JDBC going forward?
There was a problem hiding this comment.
This script build both for future reference. At the moment, repo already contains a taco for ODBC, so nothing changed for ODBC actually.
There was a problem hiding this comment.
The ODBC one is now deprecated for the JDBC one, we should stop building the ODBC one.
kylepbit
reviewed
Dec 17, 2021
.github/workflows/bi-connectors.yml
Outdated
| run: | | ||
| zip OpenSearchProject.mez *.png *.m *.resx *.pqm | ||
| working-directory: bi-connectors/PowerBIConnector | ||
| - name: Prepare the second Power BI ODBC connector |
There was a problem hiding this comment.
There are 2 connector requested by Amazon: one for OpenSearch Project which is being build from the repo as is; and the second one - for Amazon OpenSearch Service. To build the second one we need to modify few strings in the connector code.
There was a problem hiding this comment.
Can you then name them accordingly instead of "the second one"?
…rs-AOS-253 Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com>
… shipping Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com>
Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com>
Removed Tableau ODBC driver source files since the driver is not supposed to be. Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com>
kylepbit
reviewed
Dec 20, 2021
.github/workflows/bi-connectors.yml
Outdated
| working-directory: bi-connectors/TableauConnector/opensearch_sql_jdbc | ||
| - name: Prepare Power BI ODBC connector | ||
| run: | | ||
| cp SqlOdbcPBIConnector.pq SqlOdbcPBIConnector.m |
There was a problem hiding this comment.
Are these names right after the rebranding that occurred?
…erge Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com>
kylepbit
approved these changes
Dec 21, 2021
ghost
merged commit
This was referenced Dec 21, 2021
matthewryanwells
pushed a commit
that referenced
this pull request
Aug 21, 2023
(opensearch-project#1988) * spotless apply for OpenSearch P1. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Manual spotless changes Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * spotless apply for OpenSearch P2. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * 90 files checked after spotless apply for legacy Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Added checkstyle ignore failures to legacy Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Fixed comma issue Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Spotless apply Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Revert build.gradle Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> --------- Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com>
MitchellGale
added a commit
that referenced
this pull request
Aug 22, 2023
(opensearch-project#1988) * spotless apply for OpenSearch P1. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Manual spotless changes Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * spotless apply for OpenSearch P2. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * 90 files checked after spotless apply for legacy Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Added checkstyle ignore failures to legacy Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Fixed comma issue Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Spotless apply Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Revert build.gradle Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> --------- Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Renamed Power BI connector as "OpenSearch Project"
Added a new GitHub workflow to build (pack) BI connectors, steps are:
pack Tableau ODBC connectorhttps://github.com/Bit-Quill/opensearch-project-sql/actions/runs/1593959072
Issues Resolved
AOS-253
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.