Add Day_Of_Month Function As An Alias Of DayOfMonth #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: GabeFernandez310 <gabrielf@bitquilltech.com>
Codecov Report
@@ Coverage Diff @@
## integ-add-day_of_month-function-alt #194 +/- ##
======================================================================
Coverage ? 95.83%
Complexity ? 3544
======================================================================
Files ? 356
Lines ? 9402
Branches ? 674
======================================================================
Hits ? 9010
Misses ? 334
Partials ? 58
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
acarbonetto
approved these changes
Dec 19, 2022
| ); | ||
| } | ||
|
|
||
| public void testInvalidDayOfMonth(String date) { |
| @@ -430,6 +430,64 @@ public void dayOfMonth() { | |||
| assertEquals(integerValue(8), eval(expression)); | |||
| } | |||
|
|
|||
| public void testDayOfMonthWithUnderscores(FunctionExpression dateExpression, int dayOfMonth) { | |||
docs/user/dql/functions.rst
Outdated
| Description | ||
| >>>>>>>>>>> | ||
|
|
||
| Usage: day_of_month(date) extracts the day of the month for date, in the range 1 to 31. The dates with value 0 such as '0000-00-00' or '2008-00-00' are invalid. |
There was a problem hiding this comment.
nit: This seems obvious, but I see that it was included in the synonym functions...
If you'd like, we could remove it from all of the functions.
The dates with value 0 such as '0000-00-00' or '2008-00-00' are invalid.
There was a problem hiding this comment.
I agree it's kind of obvious. I will remove it for now and in my PR upstream just add it back in if Amazon wants it back.
docs/user/dql/functions.rst
Outdated
| | 26 | | ||
| +------------------------------+ | ||
|
|
||
| os> SELECT DAY_OF_MONTH(DATE('2020-08-26')) |
There was a problem hiding this comment.
all of these similar tests are covered by IT tests. We can just have the one example in the documentation.
Yury-Fridlyand
requested review from
Yury-Fridlyand,
forestmvey,
GumpacG,
margarit-h,
MaxKsyunz and
MitchellGale
GumpacG
approved these changes
Dec 20, 2022
Signed-off-by: GabeFernandez310 <gabrielf@bitquilltech.com>
Addressed in 878a6a1 |
margarit-h
approved these changes
Dec 21, 2022
Signed-off-by: GabeFernandez310 <gabrielf@bitquilltech.com>
Signed-off-by: GabeFernandez310 <gabrielf@bitquilltech.com>
Signed-off-by: GabeFernandez310 <gabrielf@bitquilltech.com>
Signed-off-by: GabeFernandez310 <gabrielf@bitquilltech.com>
GabeFernandez310
requested review from
Yury-Fridlyand
and removed request for
MitchellGale
core/src/main/java/org/opensearch/sql/expression/datetime/DateTimeFunction.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/opensearch/sql/expression/datetime/DateTimeFunction.java
Show resolved
Hide resolved
core/src/main/java/org/opensearch/sql/expression/datetime/DateTimeFunction.java
Outdated
Show resolved
Hide resolved
core/src/test/java/org/opensearch/sql/expression/datetime/DateTimeFunctionTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: GabeFernandez310 <gabrielf@bitquilltech.com>
Signed-off-by: GabeFernandez310 <gabrielf@bitquilltech.com>
Yury-Fridlyand
approved these changes
Jan 5, 2023
GabeFernandez310
added a commit
that referenced
this pull request
Jan 5, 2023
Added Implementation And Testing For Day_Of_Month Function Signed-off-by: GabeFernandez310 <gabrielf@bitquilltech.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for the
day_of_monthfunction as an alias for thedayofmonthfunction which currently exists in opensearchIssues Resolved
#722
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.