Support Alternate Date Formats #258

GabeFernandez310 · 2023-04-10T15:28:24Z

Description

Supports using date formats obtained from OpenSearch. Contains some changes from OpenSearchDataType rework (8b2f65d). Resolves some issues previously seen on the forum (please see Issues Resolved section below). This also adds support to use custom formats in the index mapping. Valid custom formats must have enough information to be parsed as a Date, Time, or Timestamp, and otherwise throw an exception after failing to parse.

Currently failing due to test failures likely unrelated to these specific changes

Based on PoC (Here: https://github.com/Bit-Quill/opensearch-project-sql/pull/169/files). Therefore, it also fails to parse the same formats as those listed in the PoC.

Note: With this change, issues may be introduced where data is read differently if a user's mapping defines a format. This is because the plugin previously used a hardcoded formatter to parse the data, while with these changes it will use the formatter defined in the mapping.

Supported formats include the following:

epoch_millis
epoch_millis
epoch_second
date_optional_time
strict_date_optional_time
strict_date_optional_time_nanos
basic_date
basic_date_time
basic_date_time_no_millis
basic_ordinal_date
basic_ordinal_date_time
basic_ordinal_date_time_no_millis
basic_time
basic_time_no_millis
basic_t_time
basic_t_time_no_millis
basic_week_date
strict_basic_week_date
basic_week_date_time
strict_basic_week_date_time
basic_week_date_time_no_millis
strict_basic_week_date_time_no_millis
date
strict_date
date_hour
strict_date_hour
date_hour_minute
strict_date_hour_minute
date_hour_minute_second
strict_date_hour_minute_second
date_hour_minute_second_fraction
strict_date_hour_minute_second_fraction
date_hour_minute_second_millis
strict_date_hour_minute_second_millis
date_time
strict_date_time
date_time_no_millis
strict_date_time_no_millis
hour
strict_hour
hour_minute
strict_hour_minute
hour_minute_second
strict_hour_minute_second
hour_minute_second_fraction
strict_hour_minute_second_fraction
hour_minute_second_millis
strict_hour_minute_second_millis
ordinal_date
strict_ordinal_date
ordinal_date_time
strict_ordinal_date_time
ordinal_date_time_no_millis
strict_ordinal_date_time_no_millis
time
strict_time
time_no_millis
strict_time_no_millis
t_time
strict_t_time
t_time_no_millis
strict_t_time_no_millis
week_date
strict_week_date
week_date_time
strict_week_date_time
week_date_time_no_millis
strict_week_date_time_no_millis
weekyear_week_day
strict_weekyear_week_day
year_month_day
strict_year_month_day
yyyy-MM-dd
HH:mm:ss
yyyy-MM-dd||uuuu-DDD
hour_minute_second||t_time

The following formats are not supported as no default formatters are available for these from OpenSearch core.

weekyear
strictweekyear
year
strict_year
year_month
strict_year_month

Issues Resolved

opensearch-project#794
https://forum.opensearch.org/t/sql-select-fails-on-date-fields-format-epoch-second/11521

Check List

New functionality includes testing.
- All tests pass, including unit test, integration test and doctest
New functionality has been documented.
- New functionality has javadoc added
- New functionality has user manual doc added
Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…Search types Signed-off-by: Andrew Carbonetto <andrewc@bitquilltech.com>

Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>

integ-test/src/test/java/org/opensearch/sql/legacy/AggregationExpressionIT.java

opensearch/src/main/java/org/opensearch/sql/opensearch/data/type/OpenSearchDataType.java

opensearch/src/main/java/org/opensearch/sql/opensearch/data/type/OpenSearchDateType.java

acarbonetto · 2023-04-14T15:57:59Z

opensearch/src/main/java/org/opensearch/sql/opensearch/data/type/OpenSearchDateType.java

+
+  public List<DateFormatter> getNamedFormatters(String formats) {
+    return getFormatList(formats).stream().filter(f -> {
+          try {


try... catch blocks are inefficient (compared with a boolean comparison) and shouldn't be used in loops or streams.
Much better to filter on the patterns of acceptable strings.
If there's some edge cases, you can include a try...catch around the entire stream.

acarbonetto · 2023-04-14T15:58:20Z

opensearch/src/main/java/org/opensearch/sql/opensearch/data/type/OpenSearchDateType.java

+  public List<DateTimeFormatter> getRegularFormatters() {
+    return getFormatList(formatString).stream().map(f -> {
+          try {
+            return DateTimeFormatter.ofPattern(f);


same here. avoid using try...catch within a loop or stream.

Probably this is the only way to distinguish formatters.
I tried to reuse (call) some methods from OpenSearch core libs, but they are not exported.

Haha I tried to do the exact same thing 😆. I agree. There probably is not another way to do this.

opensearch/src/main/java/org/opensearch/sql/opensearch/data/type/OpenSearchDateType.java

Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>

codecov · 2023-04-18T15:44:30Z

Codecov Report

Merging #258 (4e9bb15) into integ-support-date-formats (b90065f) will decrease coverage by 2.81%.
The diff coverage is 100.00%.

@@                       Coverage Diff                        @@
##             integ-support-date-formats     #258      +/-   ##
================================================================
- Coverage                         99.98%   97.17%   -2.81%     
- Complexity                         2493     4136    +1643     
================================================================
  Files                               193      372     +179     
  Lines                              5720    10421    +4701     
  Branches                            359      707     +348     
================================================================
+ Hits                               5719    10127    +4408     
- Misses                                1      287     +286     
- Partials                              0        7       +7

Flag	Coverage Δ
sql-engine	`97.17% <100.00%> (-2.81%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...ch/sql/opensearch/client/OpenSearchNodeClient.java	`100.00% <100.00%> (ø)`
...ch/sql/opensearch/client/OpenSearchRestClient.java	`100.00% <100.00%> (ø)`
...h/sql/opensearch/data/type/OpenSearchDataType.java	`100.00% <100.00%> (ø)`
...h/sql/opensearch/data/type/OpenSearchDateType.java	`100.00% <100.00%> (ø)`
...h/sql/opensearch/data/type/OpenSearchTextType.java	`100.00% <100.00%> (ø)`
...nsearch/data/value/OpenSearchExprValueFactory.java	`100.00% <100.00%> (ø)`
...pensearch/sql/opensearch/mapping/IndexMapping.java	`100.00% <100.00%> (ø)`

... and 172 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>

… With Datetime Types Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>

opensearch/src/main/java/org/opensearch/sql/opensearch/data/type/OpenSearchDataType.java

Yury-Fridlyand · 2023-04-18T20:44:07Z

opensearch/src/main/java/org/opensearch/sql/opensearch/data/type/OpenSearchDateType.java

+  public List<DateTimeFormatter> getRegularFormatters() {
+    return getFormatList(formatString).stream().map(f -> {
+          try {
+            return DateTimeFormatter.ofPattern(f);


Probably this is the only way to distinguish formatters.
I tried to reuse (call) some methods from OpenSearch core libs, but they are not exported.

opensearch/src/main/java/org/opensearch/sql/opensearch/data/type/OpenSearchDateType.java

opensearch/src/test/java/org/opensearch/sql/opensearch/data/type/OpenSearchDataTypeTest.java

Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>

Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com> (cherry picked from commit c91f48d9763499940ecf302212fcd592aecb6018)

…earch-project-sql into dev-support-date-formats

Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>

opensearch/src/main/java/org/opensearch/sql/opensearch/data/type/OpenSearchTextType.java

Yury-Fridlyand · 2023-04-25T18:59:06Z

...earch/src/main/java/org/opensearch/sql/opensearch/data/value/OpenSearchExprValueFactory.java

+      new DateTimeFormatterBuilder()
+          .appendOptional(SQL_LITERAL_DATE_TIME_FORMAT)
+          .appendOptional(STRICT_DATE_OPTIONAL_TIME_FORMATTER)
+          .appendOptional(STRICT_HOUR_MINUTE_SECOND_FORMATTER);


As I understand, you use 3 hardcoded formats instead of formats from mapping

I think this should be fine? This is only slightly modified from how it was implemented here (I modified it as a potential way to try and use user-defined formats). However, this might not even be needed anymore. constructTimestamp is only called in one place, if the call to parseTimestampString fails to parse the value, so probably the call to to constructTimestamp isn't even needed. I will try to rework.

opensearch/src/test/java/org/opensearch/sql/opensearch/data/type/OpenSearchDataTypeTest.java

…ct-sql into dev-support-date-formats

Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>

…ct-sql into dev-support-date-formats

Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>

…nsearch-project-sql into dev-support-date-formats

Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>

acarbonetto · 2023-04-27T16:40:21Z

@GabeFernandez310 can you please add a use case to the PR description?
It would also be worthwhile to list the supported date formats for this PR (link).

If there are any 'breaking' changes, please list them in the PR description. I believe, the only breaking changes would happen if a date format was defined for a mapping which was previously unused - and now it may not resolve that date if the date doesn't match the default format AND the format provided doesn't include the default type.

Honestly, the above change seems like it would be bad data anyways... so is this really a breaking change?

acarbonetto · 2023-04-27T16:43:35Z

integ-test/src/test/java/org/opensearch/sql/legacy/PrettyFormatResponseIT.java

@@ -483,6 +484,7 @@ public void joinQuerySelectOnlyOnOneTable() throws Exception {
    assertContainsData(getDataRows(response), fields);
  }

+  @Disabled("Disabled temporarily due to JSON format incompatibility with V2 and Legacy")


what do you mean by this? Is this test case now supported in V2 and it fails?

This may have been a mistake. I think this was failing due to the data type refactor at first, and when I asked about it JSON format was the reason that was suggested for why it started failing all of a sudden, so I just put that as the description. This has been fixed since then, so I will remove these annotations.

Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>

* Keep up with refactoring in OpenSearch. Signed-off-by: MaxKsyunz <maxk@bitquilltech.com> * Updating code formatting. Signed-off-by: MaxKsyunz <maxk@bitquilltech.com> --------- Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>

acarbonetto · 2023-04-27T16:44:54Z

integ-test/src/test/resources/date_formats.json

+{"index": {}}
+{"name": "yyyy-MM-dd||uuuu-DDD", "yyyy-MM-dd||uuuu-DDD": "1984-04-12"}
+{"index": {}}
+{"name": "hour_minute_second||t_time", "hour_minute_second||t_time": "09:07:42"}


Can we add multi-format field that covers both dates and times?

acarbonetto · 2023-04-27T16:46:19Z

integ-test/src/test/resources/date_formats.json

+{"index": {}}
+{"name": "HH:mm:ss", "HH:mm:ss": "09:07:42"}
+{"index": {}}
+{"name": "yyyy-MM-dd||uuuu-DDD", "yyyy-MM-dd||uuuu-DDD": "1984-04-12"}


we should have data that formats to each of the provided date formats to make sure that they are all working.
ie add data that conforms to uuuu-DDD format

acarbonetto · 2023-04-27T16:46:52Z

integ-test/src/test/resources/date_formats.json

+{"index": {}}
+{"name": "yyyy-MM-dd||uuuu-DDD", "yyyy-MM-dd||uuuu-DDD": "1984-04-12"}
+{"index": {}}
+{"name": "hour_minute_second||t_time", "hour_minute_second||t_time": "09:07:42"}


please add data that is formatted by the t_time formatter

acarbonetto · 2023-04-27T17:27:20Z

opensearch/src/main/java/org/opensearch/sql/opensearch/data/type/OpenSearchDataType.java

+   */
+  public static Map<String, OpenSearchDataType> parseMapping(Map<String, Object> indexMapping) {
+    Map<String, OpenSearchDataType> result = new LinkedHashMap<>();
+    if (indexMapping != null) {


nit: I prefer to fail early on functions. e.g.

if (indexMapping == null) { return result; } ...

acarbonetto · 2023-04-27T17:28:24Z

opensearch/src/main/java/org/opensearch/sql/opensearch/data/type/OpenSearchDataType.java

+    switch (mappingType) {
+      case Object:
+      case Nested:
+        if (innerMap.isEmpty()) {


I wonder if this should be applied prior to the switch as really any innerMap that's empty should just return the cached instance.

acarbonetto · 2023-04-27T18:19:32Z

...earch/src/main/java/org/opensearch/sql/opensearch/data/value/OpenSearchExprValueFactory.java

-      return new ExprTimestampValue(Instant.ofEpochMilli(value.longValue()));
+      return formatReturn(
+          returnFormat,
+          new ExprTimestampValue(Instant.ofEpochMilli(value.longValue())));
    } else if (value.isString()) {


else not required

acarbonetto · 2023-04-27T18:20:15Z

...earch/src/main/java/org/opensearch/sql/opensearch/data/value/OpenSearchExprValueFactory.java

+                "Construct ExprTimestampValue from \"%s\" failed, unsupported date format.",
+                value.stringValue()),
+            ignored);
+      }
    } else {


else not required, as the other options all return/throw

acarbonetto · 2023-04-27T18:22:43Z

...earch/src/main/java/org/opensearch/sql/opensearch/data/value/OpenSearchExprValueFactory.java

+      dt = (OpenSearchDateType) type;
+      returnFormat = dt.getExprType();
+    } else {
+      dt = OpenSearchDateType.of();


Why would this happen? I mean, when would we parseTimestamp on a non-date type?

Probably needs to be reworked. Currently typeActionMap still uses an OpenSearchDataType created from an ExprCoreType in some places. I believe I tried to change this at some point, but was seeing test failures because in the case that an OpenSearchDataType is passed in, it was failing on the line

dt = (OpenSearchDateType) type;

because it could not cast the passed in type argument to an OpenSearchDateType.

This if-else branch may just need to be removed, and the code may need to be updated wherever the parseTimestamp function is called using a type argument that is not an OpenSearchDateType.

opensearch/src/test/java/org/opensearch/sql/opensearch/data/type/OpenSearchDataTypeTest.java

acarbonetto · 2023-04-27T20:44:00Z

...est/java/org/opensearch/sql/opensearch/storage/script/filter/ExpressionFilterScriptTest.java

@@ -28,6 +28,7 @@
 import java.util.Map;
 import lombok.RequiredArgsConstructor;
 import org.apache.lucene.index.LeafReaderContext;
+import org.junit.Ignore;


revert this?

Yury-Fridlyand · 2023-04-27T20:45:57Z

opensearch/src/main/java/org/opensearch/sql/opensearch/data/type/OpenSearchDateType.java

+  private static final String FORMAT_DELIMITER = "\\|\\|";
+
+
+  // a read-only collection of relations


update comment

Yury-Fridlyand · 2023-04-27T20:46:03Z

opensearch/src/main/java/org/opensearch/sql/opensearch/data/type/OpenSearchDateType.java

+ * Of type join with relations. See
+ * <a href="https://opensearch.org/docs/latest/opensearch/supported-field-types/join/">doc</a>


Update comment

opensearch/src/main/java/org/opensearch/sql/opensearch/data/type/OpenSearchDateType.java

Yury-Fridlyand · 2023-04-27T20:47:16Z

opensearch/src/main/java/org/opensearch/sql/opensearch/data/type/OpenSearchDateType.java

+    var res = new OpenSearchDateType(format);
+    return res;


Can return new ...

Yury-Fridlyand · 2023-04-27T20:50:43Z

...earch/src/main/java/org/opensearch/sql/opensearch/data/value/OpenSearchExprValueFactory.java

+            returnFormat,
+            new ExprTimestampValue(
+                new ExprTimeValue(LocalTime.from(parsed))
+                    .timestampValue(new FunctionProperties(Instant.EPOCH, ZoneOffset.UTC))));


It works as LocalDate.now() I suppose.
We need a way to use here already created for this query instance of FunctionProperties.

… dev-support-date-formats

Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>

…earch-project-sql into dev-support-date-formats

Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>

GumpacG · 2023-05-08T19:17:22Z

Closing this as there will be a follow up PR to isolate the support for datetime formats only.

acarbonetto and others added 11 commits March 29, 2023 16:06

Add OpenSearchDateType as a datatype for matching with Date/Time Open…

8b2f65d

…Search types Signed-off-by: Andrew Carbonetto <andrewc@bitquilltech.com>

Added IT Test

c5ad8e0

Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>

Added Basic Implementation

a64b93e

Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>

Added A Comment

cbf3c38

Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>

Added Support For Default OpenSearch Formats

a780bbd

Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>

Code Cleanup

ffede70

Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>

Refactored 'parsetimestamp' Function

3708a6f

Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>

Cleanup

bc15e3a

Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>

Removed Unnecessary Try-Catch Block

a5fac5c

Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>

Fixed Unit Tests

9c2a7c8

Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>

Fixed IT Test

0f01283

Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>

Yury-Fridlyand reviewed Apr 14, 2023

View reviewed changes

integ-test/src/test/java/org/opensearch/sql/legacy/AggregationExpressionIT.java Outdated Show resolved Hide resolved

acarbonetto reviewed Apr 14, 2023

View reviewed changes

GabeFernandez310 added 4 commits April 17, 2023 09:32

Fixed Text Type and Disabled JSON Format Test

5c63d7f

Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>

Fix Mapping Type Reporting As Date Instead Of Timestamp In Schema

675aa02

Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>

Revert Breaking Test Changes

09d420b

Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>

Fixed Returned ExprCoreTypes

a519501

Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>

Fixed OpenSearch Type Names In Mapping

ed2bcbb

Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>

matthewryanwells approved these changes Apr 18, 2023

View reviewed changes

Fixed LegacyTypeName Function And Refactored Code To Fix Calculations…

ef90ad6

… With Datetime Types Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>

Yury-Fridlyand reviewed Apr 18, 2023

View reviewed changes

GabeFernandez310 added 8 commits April 18, 2023 15:10

Changed Support For Passing Fields Into Text Type

418dc98

Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>

Reverted Some Changes And Commented Out A Test

0670812

Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>

Commented Out A Breaking Change

5543fd8

Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>

Minor Refactoring Changes

9325d24

Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>

Reworked parseTimestamp Function To Format Return Based On Enum

89cb4ce

Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>

Fixed Returned ExprValue

2ab67ed

Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>

Reverted Changes To Test Files

bbc6526

Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>

Reverted Some Changes To Enum And Reworked Code

e07b4ca

Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>

GabeFernandez310 added 5 commits April 24, 2023 14:26

Refactored Code To Fix Integration Test

be06b94

Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com> (cherry picked from commit c91f48d9763499940ecf302212fcd592aecb6018)

Merge branch 'integ-support-date-formats' into dev-support-date-formats

5b879de

Merge branch 'dev-support-date-formats' of github.com:Bit-Quill/opens…

282cc76

…earch-project-sql into dev-support-date-formats

Addressed JaCoCo Issues

0fe9ea0

Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>

Fixed Checkstyle

debda6a

Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>

Yury-Fridlyand reviewed Apr 25, 2023

View reviewed changes

GabeFernandez310 added 7 commits April 25, 2023 14:23

Merge branch 'dev-fix-build' of github.com:Bit-Quill/opensearch-proje…

568bbf3

…ct-sql into dev-support-date-formats

Addressed PR Comments

0fba818

Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>

Changed To Throw Exception When Encountering Parsing Failures

6f7e633

Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>

Merge branch 'dev-fix-build' of github.com:Bit-Quill/opensearch-proje…

a6341ac

…ct-sql into dev-support-date-formats

Fixed Checkstyle

7fa682e

Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>

Merge branch 'integ-support-date-formats' of github.com:Bit-Quill/ope…

752a718

…nsearch-project-sql into dev-support-date-formats

Removed Unneeded Imports

ace81ea

Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>

acarbonetto reviewed Apr 27, 2023

View reviewed changes

GabeFernandez310 and others added 2 commits April 27, 2023 11:26

Re-enabled Some Tests

2ccebd9

Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>

acarbonetto reviewed Apr 27, 2023

View reviewed changes

Yury-Fridlyand reviewed Apr 27, 2023

View reviewed changes

GumpacG and others added 8 commits April 28, 2023 08:00

Merge branch 'main' of https://github.com/opensearch-project/sql into…

93f212a

… dev-support-date-formats

Merge branch 'opensearch-project:main' into dev-support-date-formats

a3de4e5

Addressed PR Comments

0df21dd

Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>

Merge branch 'dev-support-date-formats' of github.com:Bit-Quill/opens…

28c1bca

…earch-project-sql into dev-support-date-formats

Changed test data

b140170

Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>

Pulled out support for user-defined datetime formats

e95fdde

Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>

Modified IT test data

4394315

Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>

Added IT tests

4e9bb15

Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>

GumpacG closed this May 8, 2023

Yury-Fridlyand deleted the dev-support-date-formats branch July 31, 2023 18:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support Alternate Date Formats #258

Support Alternate Date Formats #258

GabeFernandez310 commented Apr 10, 2023 •

edited

Loading

acarbonetto Apr 14, 2023

acarbonetto Apr 14, 2023

Yury-Fridlyand Apr 18, 2023

GabeFernandez310 Apr 19, 2023

codecov bot commented Apr 18, 2023 •

edited

Loading

Yury-Fridlyand Apr 18, 2023

Yury-Fridlyand Apr 25, 2023

GabeFernandez310 Apr 25, 2023

acarbonetto commented Apr 27, 2023 •

edited

Loading

acarbonetto Apr 27, 2023

GabeFernandez310 Apr 27, 2023 •

edited

Loading

GabeFernandez310 Apr 27, 2023

acarbonetto Apr 27, 2023

GabeFernandez310 Apr 28, 2023

acarbonetto Apr 27, 2023

GabeFernandez310 Apr 28, 2023

acarbonetto Apr 27, 2023

GabeFernandez310 Apr 28, 2023

acarbonetto Apr 27, 2023

acarbonetto Apr 27, 2023

acarbonetto Apr 27, 2023

acarbonetto Apr 27, 2023

acarbonetto Apr 27, 2023

GabeFernandez310 Apr 28, 2023

acarbonetto Apr 27, 2023

Yury-Fridlyand Apr 27, 2023

Yury-Fridlyand Apr 27, 2023

Yury-Fridlyand Apr 27, 2023

Yury-Fridlyand Apr 27, 2023

GumpacG commented May 8, 2023

		private static final String FORMAT_DELIMITER = "\\\|\\\|";


		// a read-only collection of relations

		* Of type join with relations. See
		* <a href="https://opensearch.org/docs/latest/opensearch/supported-field-types/join/">doc</a>

Support Alternate Date Formats #258

Support Alternate Date Formats #258

Conversation

GabeFernandez310 commented Apr 10, 2023 • edited Loading

Description

Issues Resolved

Check List

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented Apr 18, 2023 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

acarbonetto commented Apr 27, 2023 • edited Loading

Choose a reason for hiding this comment

GabeFernandez310 Apr 27, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

GumpacG commented May 8, 2023

GabeFernandez310 commented Apr 10, 2023 •

edited

Loading

codecov bot commented Apr 18, 2023 •

edited

Loading

acarbonetto commented Apr 27, 2023 •

edited

Loading

GabeFernandez310 Apr 27, 2023 •

edited

Loading