-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Spotless code formatter #288
Conversation
309fb98
to
9e58da4
Compare
0e73916
to
c94e6e4
Compare
Codecov Report
@@ Coverage Diff @@
## integ/spotless #288 +/- ##
=================================================
Coverage 97.39% 97.39%
Complexity 4608 4608
=================================================
Files 401 401
Lines 11408 11408
Branches 843 843
=================================================
Hits 11111 11111
Misses 290 290
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you seen this PR?
Can you use the googleJavaFormat line from there and import wildcards check?
And similarly to https://github.com/opensearch-project/OpenSearch/blob/main/gradle/formatting.gradle, can you try applying spotless to md and rst files as well?
RST files may be a headache (could break doctest) so if it does not work well, we can do it separately.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, rebase to fix CI
Why should we use 1.15.0? |
9f63b92
to
120b5a4
Compare
|
Can |
It was the latest release at the time. The key is to specify the version of rules being used. This avoids new versions of formatting rules forcing unrelated changes to a PR. |
Ah! That makes sense, thanks. Will specify version :) |
76bbcf1
to
6874b74
Compare
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Remove commented out spotless changes. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Adding Spotless to DEVELOPER_GUIDE.rst Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Added Google Java format to spotless. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Update DEVELOPER_GUIDE.rst Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
6874b74
to
18a75bd
Compare
Signed-off-by: Naveen Tatikonda <navtat@amazon.com>
Description
Adds support for Spotless code formatter via
./gradlew spotlessApply
and./gradlew spotlessCheck
. Apply applies the checks, check notifies which changes need to be applied.Checks applied:
Issues Resolved
opensearch-project#1101
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.