-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Certificate Validation option #31
Conversation
Signed-off-by: Guian Gumpac <guiang@bitquilltech.com>
Signed-off-by: Guian Gumpac <guiang@bitquilltech.com>
Codecov Report
@@ Coverage Diff @@
## main #31 +/- ##
=========================================
Coverage 99.92% 99.92%
Complexity 2698 2698
=========================================
Files 257 257
Lines 6491 6491
Branches 402 402
=========================================
Hits 6486 6486
Misses 5 5
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Need to update version and add CHANGELOG |
Signed-off-by: Guian Gumpac <guiang@bitquilltech.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@guiangumpac I left a few comments. I realize they are very last minute.
I'd like to know what you think but feel free to treat them as informational for the purposes of this PR.
Signed-off-by: Guian Gumpac <guiang@bitquilltech.com>
Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com>
Description
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.