Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Certificate Validation option #31

Merged
5 commits merged into from
Mar 2, 2022
Merged

Add Certificate Validation option #31

5 commits merged into from
Mar 2, 2022

Conversation

ghost
Copy link

@ghost ghost commented Feb 25, 2022

Description

  • Added option to allow users to choose a certificate validation option
  • Changed beta to false
  • Updated readme and screenshots for instructions

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Guian Gumpac added 2 commits February 25, 2022 11:31
Signed-off-by: Guian Gumpac <guiang@bitquilltech.com>
Signed-off-by: Guian Gumpac <guiang@bitquilltech.com>
@ghost ghost requested review from Yury-Fridlyand, alexmeizer and MaxKsyunz February 25, 2022 23:48
@codecov
Copy link

codecov bot commented Feb 26, 2022

Codecov Report

Merging #31 (72dbb48) into main (8b58136) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main      #31   +/-   ##
=========================================
  Coverage     99.92%   99.92%           
  Complexity     2698     2698           
=========================================
  Files           257      257           
  Lines          6491     6491           
  Branches        402      402           
=========================================
  Hits           6486     6486           
  Misses            5        5           
Flag Coverage Δ
sql-engine 99.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b58136...72dbb48. Read the comment docs.

Copy link

@MaxKsyunz MaxKsyunz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost
Copy link
Author

ghost commented Feb 28, 2022

Need to update version and add CHANGELOG

Signed-off-by: Guian Gumpac <guiang@bitquilltech.com>
@ghost ghost requested review from alexmeizer and MaxKsyunz February 28, 2022 19:24
Copy link

@MaxKsyunz MaxKsyunz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guiangumpac I left a few comments. I realize they are very last minute.

I'd like to know what you think but feel free to treat them as informational for the purposes of this PR.

bi-connectors/PowerBIConnector/docs/CHANGELOG.md Outdated Show resolved Hide resolved
Signed-off-by: Guian Gumpac <guiang@bitquilltech.com>
Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com>
@ghost ghost merged commit 278c05f into main Mar 2, 2022
@Yury-Fridlyand Yury-Fridlyand deleted the pbi-connector-hostname branch May 31, 2022 21:51
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants