[Spotless] Applying Google Code Format for core/src/main files #4 #317

MitchellGale · 2023-07-27T21:35:53Z

Description

This PR applies Spotless on Java code for:
'core/src/main/java/org/opensearch/sql/ast/.java',
'core/src/main/java/org/opensearch/sql/DataSourceSchemaName.java',
'core/src/test/java/org/opensearch/sql/ast/.java',
'core/src/test/java/org/opensearch/sql/data/.java',
'core/src/test/java/org/opensearch/sql/config/.java',
'core/src/test/java/org/opensearch/sql/analysis/*.java'

Disables core checkstyle and enables spotless check for files that are fixed in this PR.

Issues Resolved

[List any issues this PR will resolve]

Check List

New functionality includes testing.
- All tests pass, including unit test, integration test and doctest
New functionality has been documented.
- New functionality has javadoc added
- New functionality has user manual doc added
Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

codecov · 2023-07-27T22:34:50Z

Codecov Report

Merging #317 (16266e8) into integ/sl_GoogleJavaFormat4 (d00dc4d) will not change coverage.
The diff coverage is n/a.

@@                      Coverage Diff                      @@
##             integ/sl_GoogleJavaFormat4     #317   +/-   ##
=============================================================
  Coverage                         97.42%   97.42%           
  Complexity                         4647     4647           
=============================================================
  Files                               408      408           
  Lines                             11526    11526           
  Branches                            839      839           
=============================================================
  Hits                              11229    11229           
  Misses                              290      290           
  Partials                              7        7

Flag	Coverage Δ
sql-engine	`97.42% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

acarbonetto

@MitchellGale looks like there are a couple of commits form vamsi in your PR. Can you rebase and remove them please?

build.gradle

core/build.gradle

core/src/main/java/org/opensearch/sql/ast/dsl/AstDSL.java

core/src/main/java/org/opensearch/sql/ast/expression/QualifiedName.java

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

…ilures for core. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

Yury-Fridlyand · 2023-08-02T21:09:16Z

core/src/main/java/org/opensearch/sql/ast/dsl/AstDSL.java

-   *     WHEN search_condition THEN result_expr
-   *     [WHEN search_condition THEN result_expr] ...
-   *     [ELSE result_expr]
+   * CASE<br>


This file already included in #312 (part 1)

Great catch! Entire **/ast directory was included in both. I removed it from this repo and will use it from PR #1.

Yury-Fridlyand · 2023-08-02T21:12:20Z

core/src/main/java/org/opensearch/sql/ast/tree/TableFunction.java

-/**
- * ASTNode for Table Function.
- */
+/** ASTNode for Table Function. */


Suggested change

/** ASTNode for Table Function. */

/** AST Node for Table Function. */

Addressed in #312

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

* Implement creation of ip2geo feature (#257) * Update gradle version to 7.6 (#265) Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com> * Implement creation of ip2geo feature * Implementation of ip2geo datasource creation * Implementation of ip2geo processor creation Signed-off-by: Heemin Kim <heemin@amazon.com> --------- Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com> Signed-off-by: Heemin Kim <heemin@amazon.com> Co-authored-by: Vijayan Balasubramanian <balasvij@amazon.com> * Added unit tests with some refactoring of codes (#271) * Add Unit tests * Set cache true for search query * Remove in memory cache implementation (Two way door decision) * Relying on search cache without custom cache * Renamed datasource state from FAILED to CREATE_FAILED * Renamed class name from *Helper to *Facade * Changed updateIntervalInDays to updateInterval * Changed value type of default update_interval from TimeValue to Long * Read setting value from cluster settings directly Signed-off-by: Heemin Kim <heemin@amazon.com> * Sync from main (#280) * Update gradle version to 7.6 (#265) Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com> * Exclude lombok generated code from jacoco coverage report (#268) Signed-off-by: Heemin Kim <heemin@amazon.com> * Make jacoco report to be generated faster in local (#267) Signed-off-by: Heemin Kim <heemin@amazon.com> * Update dependency org.json:json to v20230227 (#273) Co-authored-by: mend-for-github-com[bot] <50673670+mend-for-github-com[bot]@users.noreply.github.com> * Baseline owners and maintainers (#275) Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com> --------- Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com> Signed-off-by: Heemin Kim <heemin@amazon.com> Co-authored-by: Vijayan Balasubramanian <balasvij@amazon.com> Co-authored-by: mend-for-github-com[bot] <50673670+mend-for-github-com[bot]@users.noreply.github.com> * Add datasource name validation (#281) Signed-off-by: Heemin Kim <heemin@amazon.com> * Refactoring of code (#282) 1. Change variable name from datasourceName to name 2. Change variable name from id to name 3. Added helper methods in test code Signed-off-by: Heemin Kim <heemin@amazon.com> * Change field name from md5 to sha256 (#285) Signed-off-by: Heemin Kim <heemin@amazon.com> * Implement get datasource api (#279) Signed-off-by: Heemin Kim <heemin@amazon.com> * Update index option (#284) 1. Make geodata index as hidden 2. Make geodata index as read only allow delete after creation is done 3. Refresh datasource index immediately after update Signed-off-by: Heemin Kim <heemin@amazon.com> * Make some fields in manifest file as mandatory (#289) Signed-off-by: Heemin Kim <heemin@amazon.com> * Create datasource index explicitly (#283) Signed-off-by: Heemin Kim <heemin@amazon.com> * Add wrapper class of job scheduler lock service (#290) Signed-off-by: Heemin Kim <heemin@amazon.com> * Remove all unused client attributes (#293) Signed-off-by: Heemin Kim <heemin@amazon.com> * Update copyright header (#298) Signed-off-by: Heemin Kim <heemin@amazon.com> * Run system index handling code with stashed thread context (#297) Signed-off-by: Heemin Kim <heemin@amazon.com> * Reduce lock duration and renew the lock during update (#299) Signed-off-by: Heemin Kim <heemin@amazon.com> * Implements delete datasource API (#291) Signed-off-by: Heemin Kim <heemin@amazon.com> * Set User-Agent in http request (#300) Signed-off-by: Heemin Kim <heemin@amazon.com> * Implement datasource update API (#292) Signed-off-by: Heemin Kim <heemin@amazon.com> * Refactoring test code (#302) Make buildGeoJSONFeatureProcessorConfig method to be more general Signed-off-by: Heemin Kim <heemin@amazon.com> * Add ip2geo processor integ test for failure case (#303) Signed-off-by: Heemin Kim <heemin@amazon.com> * Bug fix and refactoring of code (#305) 1. Bugfix: Ingest metadata can be null if there is no processor created 2. Refactoring: Moved private method to another class for better testing support 3. Refactoring: Set some private static final variable as public so that unit test can use it 4. Refactoring: Changed string value to static variable Signed-off-by: Heemin Kim <heemin@amazon.com> * Add integration test for Ip2GeoProcessor (#306) Signed-off-by: Heemin Kim <heemin@amazon.com> * Add ConcurrentModificationException (#308) Signed-off-by: Heemin Kim <heemin@amazon.com> * Add integration test for UpdateDatasource API (#307) Signed-off-by: Heemin Kim <heemin@amazon.com> * Bug fix on lock management and few performance improvements (#310) * Release lock before response back to caller for update/delete API * Release lock in background task for creation API * Change index settings to improve indexing performance Signed-off-by: Heemin Kim <heemin@amazon.com> * Change index setting from read_only_allow_delete to write (#311) read_only_allow_delete does not block write to an index. The disk-based shard allocator may add and remove this block automatically. Therefore, use index.blocks.write instead. Signed-off-by: Heemin Kim <heemin@amazon.com> * Fix bug in get datasource API and improve memory usage (#313) Signed-off-by: Heemin Kim <heemin@amazon.com> * Change package for Strings.hasText (#314) (#317) Signed-off-by: Heemin Kim <heemin@amazon.com> * Remove jitter and move index setting from DatasourceFacade to DatasourceExtension (#319) Signed-off-by: Heemin Kim <heemin@amazon.com> * Do not index blank value and do not enrich null property (#320) Signed-off-by: Heemin Kim <heemin@amazon.com> * Move index setting keys to constants (#321) Signed-off-by: Heemin Kim <heemin@amazon.com> * Return null index name for expired data (#322) Return null index name for expired data so that it can be deleted by clean up process. Clean up process exclude current index from deleting. Signed-off-by: Heemin Kim <heemin@amazon.com> * Add new fields in datasource (#325) Signed-off-by: Heemin Kim <heemin@amazon.com> * Delete index once it is expired (#326) Signed-off-by: Heemin Kim <heemin@amazon.com> * Add restoring event listener (#328) In the listener, we trigger a geoip data update Signed-off-by: Heemin Kim <heemin@amazon.com> * Reverse forcemerge and refresh order (#331) Otherwise, opensearch does not clear old segment files Signed-off-by: Heemin Kim <heemin@amazon.com> * Removed parameter and settings (#332) * Removed first_only parameter * Removed max_concurrency and batch_size setting first_only parameter was added as current geoip processor has it. However, the parameter have no benefit for ip2geo processor as we don't do a sequantial search for array data but use multi search. max_concurrency and batch_size setting is removed as these are only reveal internal implementation and could be a future blocker to improve performance later. Signed-off-by: Heemin Kim <heemin@amazon.com> * Add a field in datasource for current index name (#333) Signed-off-by: Heemin Kim <heemin@amazon.com> * Delete GeoIP data indices after restoring complete (#334) We don't want to use restored GeoIP data indices. Therefore we delete the indices once restoring process complete. When GeoIP metadata index is restored, we create a new GeoIP data index instead. Signed-off-by: Heemin Kim <heemin@amazon.com> * Use bool query for array form of IPs (#335) Signed-off-by: Heemin Kim <heemin@amazon.com> * Run update/delete request in a new thread (#337) This is not to block transport thread Signed-off-by: Heemin Kim <heemin@amazon.com> * Remove IP2Geo processor validation (#336) Cannot query index to get data to validate IP2Geo processor. Will add validation when we decide to store some of data in cluster state metadata. Signed-off-by: Heemin Kim <heemin@amazon.com> * Acquire lock sychronously (#339) By acquiring lock asychronously, the remaining part of the code is being run by transport thread which does not allow blocking code. We want only single update happen in a node using single thread. However, it cannot be acheived if I acquire lock asynchronously and pass the listener. Signed-off-by: Heemin Kim <heemin@amazon.com> * Added a cache to store datasource metadata (#338) Signed-off-by: Heemin Kim <heemin@amazon.com> * Changed class name and package (#341) Signed-off-by: Heemin Kim <heemin@amazon.com> * Refactoring of code (#342) 1. Changed class name from Ip2GeoCache to Ip2GeoCachedDao 2. Moved the Ip2GeoCachedDao from cache to dao package Signed-off-by: Heemin Kim <heemin@amazon.com> * Add geo data cache (#340) Signed-off-by: Heemin Kim <heemin@amazon.com> * Add cache layer to reduce GeoIp data retrieval latency (opensearch-project#343) Signed-off-by: Heemin Kim <heemin@amazon.com> * Use _primary in query preference and few changes (opensearch-project#347) 1. Use _primary preference to get datasource metadata so that it can read the latest data. RefreshPolicy.IMMEDIATE won't refresh replica shards immediately according to #346 2. Update datasource metadata index mapping 3. Move batch size from static value to setting Signed-off-by: Heemin Kim <heemin@amazon.com> * Wait until GeoIP data to be replicated to all data nodes (opensearch-project#348) Signed-off-by: Heemin Kim <heemin@amazon.com> * Update packages according to a change in OpenSearch core (opensearch-project#354) * Update packages according to a change in OpenSearch core Signed-off-by: Heemin Kim <heemin@amazon.com> * Update packages according to a change in OpenSearch core (opensearch-project#353) Signed-off-by: Heemin Kim <heemin@amazon.com> --------- Signed-off-by: Heemin Kim <heemin@amazon.com> --------- Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com> Signed-off-by: Heemin Kim <heemin@amazon.com> Co-authored-by: Vijayan Balasubramanian <balasvij@amazon.com> Co-authored-by: mend-for-github-com[bot] <50673670+mend-for-github-com[bot]@users.noreply.github.com>

MitchellGale requested a review from matthewryanwells July 27, 2023 21:35

MitchellGale requested review from MaxKsyunz, Yury-Fridlyand, forestmvey, acarbonetto and GumpacG as code owners July 27, 2023 21:35

MitchellGale force-pushed the dev/sl_GoogleJavaFormat4 branch from 6483935 to 2990b85 Compare July 27, 2023 21:50

acarbonetto requested changes Jul 31, 2023

View reviewed changes

MitchellGale force-pushed the dev/sl_GoogleJavaFormat4 branch from 2990b85 to d4ad388 Compare July 31, 2023 20:09

GJF part 4

9174d03

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

MitchellGale force-pushed the dev/sl_GoogleJavaFormat4 branch from d4ad388 to 9174d03 Compare August 2, 2023 17:23

add build.gradle comment to mention why we are ignoring checkstyle fa…

88d772a

…ilures for core. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

Yury-Fridlyand approved these changes Aug 2, 2023

View reviewed changes

acarbonetto approved these changes Aug 2, 2023

View reviewed changes

MitchellGale added 5 commits August 2, 2023 23:39

Fix include spotless build gradle.

7462233

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

revert astDSL.JAVA

b95580d

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

revert ast changes as was covered in spotless #1 PR for GJF.

de6831d

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

Reverting commits in ast folder attempt #2

9381892

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

revert change to RaretopN.java

16266e8

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

MitchellGale merged commit 1b7fa89 into integ/sl_GoogleJavaFormat4 Aug 3, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Spotless] Applying Google Code Format for core/src/main files #4 #317

[Spotless] Applying Google Code Format for core/src/main files #4 #317

MitchellGale commented Jul 27, 2023

codecov bot commented Jul 27, 2023 •

edited

Loading

acarbonetto left a comment

Yury-Fridlyand Aug 2, 2023

MitchellGale Aug 3, 2023

Yury-Fridlyand Aug 2, 2023

MitchellGale Aug 3, 2023

	/** ASTNode for Table Function. */
	/** AST Node for Table Function. */

[Spotless] Applying Google Code Format for core/src/main files #4 #317

[Spotless] Applying Google Code Format for core/src/main files #4 #317

Conversation

MitchellGale commented Jul 27, 2023

Description

Issues Resolved

Check List

codecov bot commented Jul 27, 2023 • edited Loading

Codecov Report

acarbonetto left a comment

Choose a reason for hiding this comment

Yury-Fridlyand Aug 2, 2023

Choose a reason for hiding this comment

MitchellGale Aug 3, 2023

Choose a reason for hiding this comment

Yury-Fridlyand Aug 2, 2023

Choose a reason for hiding this comment

MitchellGale Aug 3, 2023

Choose a reason for hiding this comment

codecov bot commented Jul 27, 2023 •

edited

Loading