Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support legacy syntax for match_phrase in the new SQL engine. #59

Merged

Conversation

MaxKsyunz
Copy link

@MaxKsyunz MaxKsyunz commented May 16, 2022

These changes have already been reviewed as part of #48.

Creating another PR to bring them into the integration branch.

Description

Add support for matchphrase as an alternative spelling of match_phrase.

Mention in both SQL and PPL documentation that matchphrase is accepted
as well as match_phrase.

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Add support for matchphrase as an alternative spelling of match_phrase.

Mention in both SQL and PPL documentation that matchphrase is accepted
as well as match_phrase.

Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
@codecov
Copy link

codecov bot commented May 16, 2022

Codecov Report

Merging #59 (d6ea633) into integ-match_phrase-#185 (a7d4395) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@                    Coverage Diff                     @@
##             integ-match_phrase-#185      #59   +/-   ##
==========================================================
  Coverage                      97.67%   97.67%           
  Complexity                      2743     2743           
==========================================================
  Files                            266      267    +1     
  Lines                           6797     6809   +12     
  Branches                         433      437    +4     
==========================================================
+ Hits                            6639     6651   +12     
  Misses                           157      157           
  Partials                           1        1           
Flag Coverage Δ
sql-engine 97.67% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...arch/storage/script/filter/FilterQueryBuilder.java 100.00% <ø> (ø)
...c/main/java/org/opensearch/sql/expression/DSL.java 100.00% <100.00%> (ø)
...h/sql/expression/function/BuiltinFunctionName.java 100.00% <100.00%> (ø)
...h/sql/expression/function/OpenSearchFunctions.java 100.00% <100.00%> (ø)
...ript/filter/lucene/relevance/MatchPhraseQuery.java 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bcc0a82...d6ea633. Read the comment docs.

@MaxKsyunz MaxKsyunz merged commit fedbbed into integ-match_phrase-#185 May 16, 2022
@MaxKsyunz MaxKsyunz deleted the integ-match_phrase-#185-legacy-update-v2 branch April 27, 2023 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant