Dev match_phrase_prefix #186 required #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
June 3, 2022 17:55
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
Change generateQueries signature to use more appropriate Map type. Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
Codecov Report
@@ Coverage Diff @@
## dev-match_phrase_prefix-#186 #68 +/- ##
===============================================================
Coverage 97.66% 97.66%
- Complexity 2743 2747 +4
===============================================================
Files 268 269 +1
Lines 6772 6781 +9
Branches 435 435
===============================================================
+ Hits 6614 6623 +9
Misses 157 157
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
MaxKsyunz
changed the title
MitchellGale
approved these changes
Jun 6, 2022
Yury-Fridlyand
approved these changes
Jun 6, 2022
acarbonetto
approved these changes
Jun 6, 2022
| @@ -27,6 +27,7 @@ public class OpenSearchFunctions { | |||
| public static final int MATCH_MAX_NUM_PARAMETERS = 12; | |||
| public static final int MATCH_PHRASE_MAX_NUM_PARAMETERS = 3; | |||
| public static final int MIN_NUM_PARAMETERS = 2; | |||
| private static final int MATCH_PHRASE_PREFIX_MAX_NUM_PARAMETERS = 0; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support to SQL for
match_phrase_prefixquery function with required parameters only.Example query:
SELECT * FROM banks WHERE match_phrase_prefix(Address, "Str")Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.