Fixes?

Bit-Quill · Aug 26, 2022 · 33ad43f · 33ad43f
1 parent fda9e28
commit 33ad43f
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 20 deletions.
diff --git a/gremlin-dotnet/pom.xml b/gremlin-dotnet/pom.xml
@@ -26,6 +26,11 @@ limitations under the License.
     <artifactId>gremlin-dotnet</artifactId>
     <name>Apache TinkerPop :: Gremlin.Net</name>
     <packaging>pom</packaging>
+    <properties>
+        <!-- provides a way to convert maven.test.skip value to skipTests for use in skipping dotnet tests -->
+        <maven.test.skip>false</maven.test.skip>
+        <skipTests>${maven.test.skip}</skipTests>
+    </properties>
 
     <modules>
         <module>src</module>
@@ -58,6 +63,9 @@ limitations under the License.
                 <groupId>org.eobjects.build</groupId>
                 <artifactId>dotnet-maven-plugin</artifactId>
                 <extensions>true</extensions>
+                <configuration>
+                    <skip>${skipTests}</skip>
+                </configuration>
             </plugin>
             <!--
             there is no point to deploying the jvm stuff - there is no java source really - just poms
@@ -70,15 +78,5 @@ limitations under the License.
                 </configuration>
             </plugin>
         </plugins>
-        <pluginManagement>
-            <plugins>
-                <plugin>
-                    <groupId>org.eobjects.build</groupId>
-                    <artifactId>dotnet-maven-plugin</artifactId>
-                    <extensions>true</extensions>
-                    <version>0.24</version>
-                </plugin>
-            </plugins>
-        </pluginManagement>
     </build>
 </project>
diff --git a/gremlin-dotnet/test/pom.xml b/gremlin-dotnet/test/pom.xml
@@ -263,16 +263,6 @@ limitations under the License.
                                     <goal>exec</goal>
                                 </goals>
                                 <configuration>
-                                    <skip>${skipTests}</skip>
-                                    <executable>dotnet</executable>
-                                    <workingDirectory>./..</workingDirectory>
-                                    <arguments>
-                                        <argument>test</argument>
-                                        <argument>./Gremlin.Net.sln</argument>
-                                        <argument>/p:CollectCoverage=true</argument>
-                                        <argument>/p:CoverletOutputFormat=opencover</argument>
-                                        <argument>/p:Exclude="[*Tests?]*"</argument>
-                                    </arguments>
                                     <environmentVariables>
                                         <TEST_TRANSACTIONS>true</TEST_TRANSACTIONS>
                                     </environmentVariables>