hidapi-async: update libusb/hidapi submodule of the hidapi dep #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Compiled for macOS for testing: bitbox-bridge.zip |
benma
force-pushed
the
macos-interface-fix
branch
4 times, most recently
from
5c34f23
to
a1f4808
Compare
This fixes BitBoxSwiss#43 - a regression where libusb/hidapi would report the interface number of both (HWW and U2F) as 0 instead of 0 and 1 on macOS 13.3. The fix is to pull the upstream fix: libusb/hidapi#534. hidapi-rs was forked to benma/hidapi-rs to pull in the latest libusb/hidapi that contains the fix. This also led me down a rabbit-hole of updating the Docker base image and all sorts of dependencies. Code changes are clippy fixes. libusb dep was changed to libudev, as hidapi-rs switched to the hidraw hidapi backend by default (was libusb backend before) in ruabmbua/hidapi-rs@bbb7f3e. Docker base image updated from 16.04 to 20.04 as as 16.04 and 18.04 reached end-of-life.
Ubuntu 18 is not supported anymore by GitHub actions.
benma
force-pushed
the
macos-interface-fix
branch
from
a1f4808
to
06ef354
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #43 - a regression where libusb/hidapi would report the interface number of both (HWW and U2F) as 0 instead of 0 and 1 on macOS 13.3.
The fix is to pull the upstream fix:
libusb/hidapi#534.
hidapi-rs was forked to benma/hidapi-rs to pull in the latest libusb/hidapi that contains the fix.
This also led me down a rabbit-hole of updating the Docker base image and all sorts of dependencies.