close moonpay staging branch (merge to master) #1137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just merged #1135 see https://github.com/digitalbitbox/bitbox-wallet-app/compare/moonpay |
No address or any other kind of secure verification. We're at the mercy of Moonpay and relying on a non-compromized app at the moment. Few TODOs in the code. Those should be dealt with before merging with master.
- moved buy view into routes - added a disclaimer page with do-not-show-anymore checkbox - added coin selector (still needs correct coins) - started formatting disclamer dummy text, linebreaks only for now - made MoonPay iframe use almost whole content (minus header)
Changed the language toggle from using the A component to just a normal button element.
Currently only external links are supported, opening the url in the default browser. This allows to link to internal view, i.e. to '/exchanges'. The A component now imports and depends on the extConfig function that is used for API_TOKEN etc. in util/config.js. The jest setup currently does not support extConfig.
Added disclaimer payment, fees and security info. Added same content about security, data protection and list of exchanges to the guide.
The dropdown now asynchroniously checks each account if buying is supported and only shows those accounts. This happens so fast that a loading indicator looks like a bad flicker therefore dropping the loading message. If there is only one account/coin it will now go straight to the Moonpay view. Note this now happens in testmode as tltc is disabled and there is only tbtc. To test the account dropdown enable legacy split accounts feature, to have multiple tbtc accounts. If 'legacy separate accounts by address type' is enabled the MoonPay disclaimer should show 'Buy Bitcoin' for any btc style scriptTpyes else it shows 'Buy crypto'.
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closing the staging branch. rest of the small fixes will be on master directly.