Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: install nsis without pre #2691

Closed
wants to merge 1 commit into from

Conversation

thisconnect
Copy link
Collaborator

The -pre flag is used with Chocolatey, a package manager for Windows.
This flag specifies that Chocolatey should install a pre-release
version of the software package, if available.

This commit removes -pre flag to test if appveyor ci still fails
at installing nsis.

@thisconnect
Copy link
Collaborator Author

lol lucky guess. Or is this just a coincident that it passed 🤔

@thisconnect thisconnect requested a review from Beerosagos April 29, 2024 07:16
@thisconnect
Copy link
Collaborator Author

actually now also appveyor passed in a different PR without this change

#2686

@thisconnect thisconnect removed the request for review from Beerosagos April 29, 2024 07:29
The -pre flag is used with Chocolatey, a package manager for Windows.
This flag specifies that Chocolatey should install a pre-release
version of the software package, if available.

This commit removes -pre flag to test if appveyor ci still fails
at installing nsis.
@thisconnect
Copy link
Collaborator Author

rebased

@thisconnect
Copy link
Collaborator Author

now some backend test failed 🤔

 === RUN   TestAccountsByKeystore
    accounts_test.go:1435: 
        	Error Trace:	/opt/go/src/github.com/digitalbitbox/bitbox-wallet-app/backend/accounts_test.go:1435
        	Error:      	"[0xc000584100 0xc000554580 0xc000585700 0xc000554b00 0xc000554000]" should have 3 item(s), but has 5
        	Test:       	TestAccountsByKeystore
--- FAIL: TestAccountsByKeystore (0.12s)

@thisconnect
Copy link
Collaborator Author

this was just a test. closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant