Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frontend: use darkmode colors for scrollbar #3040

Merged

Conversation

thisconnect
Copy link
Collaborator

No description provided.

@thisconnect thisconnect force-pushed the frontend-improve-scrollbars branch 3 times, most recently from cca5572 to 1618af3 Compare November 11, 2024 13:38
@thisconnect thisconnect changed the title frontend/qt: add css class to target macos platform frontend: use darkmode colors for scrollbar Nov 11, 2024
@thisconnect
Copy link
Collaborator Author

before (master):

Screenshot 2024-11-11 at 14 39 41 Screenshot 2024-11-11 at 14 42 20 Screenshot 2024-11-11 at 14 39 57 Screenshot 2024-11-11 at 14 42 05

@thisconnect
Copy link
Collaborator Author

with this change:

Screenshot 2024-11-11 at 14 44 02 Screenshot 2024-11-11 at 14 45 05 Screenshot 2024-11-11 at 14 44 13 Screenshot 2024-11-11 at 14 44 33

@thisconnect thisconnect marked this pull request as ready for review November 11, 2024 14:02
@thisconnect
Copy link
Collaborator Author

also fixes disclaimer scrollbar in darkmode

before:

Screenshot 2024-11-11 at 15 03 47

after:

Screenshot 2024-11-11 at 15 03 56

Copy link
Collaborator

@shonsirsha shonsirsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

}


Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: extra space? 🙈

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oups missed 😇

@thisconnect thisconnect merged commit 5414f46 into BitBoxSwiss:master Nov 12, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants