Maint/reduce events merge sliders #1612
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickeZ
force-pushed
the
maint/reduce-events-merge-sliders
branch
4 times, most recently
from
ac7d972 to
6d12349
Compare
benma
reviewed
Oct 1, 2025
NickeZ
force-pushed
the
maint/reduce-events-merge-sliders
branch
4 times, most recently
from
3bcef19 to
88c6c5c
Compare
Refactor code to get rid of more events. Inline the event slider data into the event.
NickeZ
force-pushed
the
maint/reduce-events-merge-sliders
branch
from
88c6c5c to
65f5b52
Compare
benma
approved these changes
Oct 1, 2025
| case EVENT_TOP_CONTINUOUS_TAP: | ||
| if (ks_data->location == top_slider && slider_data->position > SLIDER_POSITION_ONE_THIRD && | ||
| slider_data->position <= SLIDER_POSITION_TWO_THIRD) { | ||
| case EVENT_CONTINUOUS_TAP: |
There was a problem hiding this comment.
just remove ks_data->location? it is always top_slider, and the event handling wouldn't even work if it was bottom_slider. (separate commit please if you do it)
There was a problem hiding this comment.
done as separate commit
benma
approved these changes
Oct 1, 2025
The keyboard switcher is only used from the top so remove the option to create it in the bottom location. This simplifies the event hander.
NickeZ
force-pushed
the
maint/reduce-events-merge-sliders
branch
from
a771c76 to
69f124b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on #1607