Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ETH: Add message signing #321

Merged
merged 1 commit into from
Feb 11, 2020
Merged

ETH: Add message signing #321

merged 1 commit into from
Feb 11, 2020

Conversation

NickeZ
Copy link
Collaborator

@NickeZ NickeZ commented Feb 3, 2020

I need a conceptACK of this before continuing.

edit: reference for reference: https://github.com/ethereum/wiki/wiki/JSON-RPC#eth_sign
prusnak reaction: ethereum/go-ethereum#14794
You can verify signature here: https://etherscan.io/verifySig

@NickeZ NickeZ requested a review from benma February 3, 2020 15:47
Copy link
Collaborator

@benma benma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

concept ACK

src/apps/eth/eth_sign_msg.c Outdated Show resolved Hide resolved
src/apps/eth/eth_sign_msg.c Outdated Show resolved Hide resolved
src/apps/eth/eth_sign_msg.c Outdated Show resolved Hide resolved
src/apps/eth/eth_sign_msg.c Outdated Show resolved Hide resolved
src/apps/eth/eth_sign_msg.c Outdated Show resolved Hide resolved
@NickeZ NickeZ force-pushed the eth-sign-msg branch 5 times, most recently from df00cf8 to 13f3c1c Compare February 4, 2020 13:38
@NickeZ NickeZ changed the title wip add eth signing Add eth signing Feb 4, 2020
@NickeZ NickeZ changed the title Add eth signing ETH: Add message signing Feb 4, 2020
@NickeZ
Copy link
Collaborator Author

NickeZ commented Feb 4, 2020

@benma rereview bitte

@NickeZ NickeZ force-pushed the eth-sign-msg branch 2 times, most recently from 6ad56e0 to 4aa0fc7 Compare February 4, 2020 14:38
@codecov-io
Copy link

codecov-io commented Feb 4, 2020

Codecov Report

Merging #321 into master will decrease coverage by 40.34%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #321       +/-   ##
=========================================
- Coverage   40.34%     0%   -40.35%     
=========================================
  Files          97     98        +1     
  Lines        5998   6063       +65     
=========================================
- Hits         2420      0     -2420     
- Misses       3578   6063     +2485
Impacted Files Coverage Δ
src/commander/commander_eth.c 0% <0%> (ø) ⬆️
src/apps/eth/eth_sign_msg.c 0% <0%> (ø)
src/apps/btc/btc_bip143.c 0% <0%> (-100%) ⬇️
src/workflow/cancel.c 0% <0%> (-100%) ⬇️
src/workflow/status.c 0% <0%> (-100%) ⬇️
src/apps/btc/btc_params.c 0% <0%> (-100%) ⬇️
src/apps/btc/confirm_locktime_rbf.c 0% <0%> (-100%) ⬇️
src/ui/event_handler.c 0% <0%> (-100%) ⬇️
src/salt.c 0% <0%> (-100%) ⬇️
src/apps/eth/eth_sign.c 0% <0%> (-96.56%) ⬇️
... and 41 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1547ea...08ba57b. Read the comment docs.

@NickeZ NickeZ force-pushed the eth-sign-msg branch 16 times, most recently from 2d5cd3a to 8d85f82 Compare February 10, 2020 23:46
@NickeZ NickeZ force-pushed the eth-sign-msg branch 3 times, most recently from bb7c748 to 11dcf76 Compare February 10, 2020 23:59
@NickeZ NickeZ merged commit 08ba57b into BitBoxSwiss:master Feb 11, 2020
@NickeZ NickeZ deleted the eth-sign-msg branch March 6, 2020 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants