chore: move usd and ofc coins to sdk-core #2543
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmcshinsky-bitgo
force-pushed
the
BG-52418-refactor-usd-coins-and-ofc-into-bitgo-sdk-core
branch
from
b2a5330 to
4ef9da2
Compare
bitgoAaron
reviewed
Jul 19, 2022
modules/account-lib/src/index.ts
Outdated
Contributor
There was a problem hiding this comment.
I don't think there was ever any actual implementation here. This is fine for now I suppose, but we could have just as easily deleted all the XRP stuff from account-lib since it was all just boilerplate throwing not implemented exceptions.
Contributor
Author
There was a problem hiding this comment.
True, I'll delete it.
bitgoAaron
reviewed
Jul 19, 2022
modules/bitgo/src/v2/coins/index.ts
Outdated
Contributor
There was a problem hiding this comment.
don't think this comment applies any longer, we can delete the TODO
mmcshinsky-bitgo
force-pushed
the
BG-52418-refactor-usd-coins-and-ofc-into-bitgo-sdk-core
branch
from
4ef9da2 to
e5fa975
Compare
bitgoAaron
approved these changes
Jul 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BG-52418