Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cosmos): added redelegation for cosmos coins #4356

Merged
merged 1 commit into from
Mar 25, 2024
Merged

feat(cosmos): added redelegation for cosmos coins #4356

merged 1 commit into from
Mar 25, 2024

Conversation

Qxr2427
Copy link
Contributor

@Qxr2427 Qxr2427 commented Mar 19, 2024

@Qxr2427 Qxr2427 marked this pull request as ready for review March 21, 2024 04:15
@Qxr2427 Qxr2427 requested review from a team as code owners March 21, 2024 04:15
@Qxr2427
Copy link
Contributor Author

Qxr2427 commented Mar 21, 2024

added tests only for bld and atom. Do we need tests for other cosmos coins as well?

zahin-mohammad
zahin-mohammad reviewed Mar 25, 2024
View reviewed changes
Copy link
Contributor

@zahin-mohammad zahin-mohammad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update codeowners, wallets should not be a required reviewer for sdk-coin-XYZ

@noel-bitgo noel-bitgo merged commit b6a0d8e into master Mar 25, 2024
7 checks passed
@Ernel1997 Ernel1997 mentioned this pull request Oct 12, 2024
Open
@Matthelonianxl Matthelonianxl mentioned this pull request Oct 18, 2024
Open
@Ernel1997 Ernel1997 mentioned this pull request Oct 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zahin-mohammad zahin-mohammad zahin-mohammad left review comments

@noel-bitgo noel-bitgo noel-bitgo approved these changes

@OttoAllmendinger OttoAllmendinger OttoAllmendinger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Qxr2427 @OttoAllmendinger @zahin-mohammad @noel-bitgo