feat(abstract-eth): fetch gasPrice and gasLimit from explorer #4905
Conversation
venkateshv1266
force-pushed
the
COIN-1201-wrw-update-fields-to-get-gas-fees-and-gasLimit-from-explorer
branch
from
8a9ee61
to
3a75ae4
Compare
venkateshv1266
changed the title
venkateshv1266
force-pushed
the
COIN-1201-wrw-update-fields-to-get-gas-fees-and-gasLimit-from-explorer
branch
2 times, most recently
from
ab0299b
to
6e784b3
Compare
| @@ -1520,10 +1520,14 @@ export abstract class AbstractEthLikeNewCoins extends AbstractEthLikeCoin { | |||
| } | |||
| } | |||
|
|
|||
| const gasLimit = new optionalDeps.ethUtil.BN(this.setGasLimit(params.gasLimit)); | |||
| // If gasLimit is not passed as a param, then default gasLimit 50000 will be set here | |||
| let gasLimit = new optionalDeps.ethUtil.BN(this.setGasLimit(params.gasLimit)); | |||
There was a problem hiding this comment.
I don't think this is needed, we can do the balance check after we get the correct gasLimit
also we shouldn't pass any default values for fee and gasLimit from wrw
There was a problem hiding this comment.
No, actually we are not passing any default values from WRW.
There was a problem hiding this comment.
I added the balance check after we get the gasLimit from explorer
venkateshv1266
force-pushed
the
COIN-1201-wrw-update-fields-to-get-gas-fees-and-gasLimit-from-explorer
branch
2 times, most recently
from
56e528b
to
c9afb5e
Compare
venkateshv1266
force-pushed
the
COIN-1201-wrw-update-fields-to-get-gas-fees-and-gasLimit-from-explorer
branch
from
c9afb5e
to
2a8f36e
Compare
| @@ -1520,25 +1520,20 @@ export abstract class AbstractEthLikeNewCoins extends AbstractEthLikeCoin { | |||
| } | |||
| } | |||
|
|
|||
| const gasLimit = new optionalDeps.ethUtil.BN(this.setGasLimit(params.gasLimit)); | |||
| // Use default gasLimit for cold and custody wallets | |||
| let gasLimit = | |||
There was a problem hiding this comment.
actually is gasLimit mandatory for tx building if not we can just fetch it at the WP
There was a problem hiding this comment.
yes, it is mandatory to pass gasLimit... If not, it will throw an error while building the txn Error: Cannot convert string to buffer. toBuffer only supports 0x-prefixed hex strings and this string was given: 0xNaN
TICKET: COIN-1201