feat(sdk-coin-tao): add netuid validation #5657
Open
+33
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * Helper method to check whether netuid is 0 (only root network is supported now) | ||
| * @param {string} netduid of the subnet | ||
| */ | ||
| public validateNetuid(netduid: string) { |
There was a problem hiding this comment.
We only check if it's 0? What if it's some other type of string value?
There was a problem hiding this comment.
Netuid is being sent from staking service to WP as 0; indicates which subnet and currently only root subnet (0) is being used
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: SC-1044
Only root subnet (0) is supported as of today