feat: add approveToken function for erc20 sendMany #5842
+262
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamleshmugdiya
force-pushed
the
COIN-2785
branch
2 times, most recently
from
b8051d2 to
fbcf6a5
Compare
kamleshmugdiya
force-pushed
the
COIN-2785
branch
from
fbcf6a5 to
af0762e
Compare
| @@ -899,4 +899,5 @@ export interface IWallet { | |||
| fetchCrossChainUTXOs(params: FetchCrossChainUTXOsOptions): Promise<CrossChainUTXO[]>; | |||
| getChallengesForEcdsaSigning(): Promise<WalletEcdsaChallenges>; | |||
| getNftBalances(): Promise<NftBalance[]>; | |||
| approveToken(walletPassphrase: string, tokenName: string): Promise<any>; | |||
There was a problem hiding this comment.
There's no more strict return type we can use here other than any ?
There was a problem hiding this comment.
using existing SubmitTransactionResponse.
also added test and an example script.
kamleshmugdiya
force-pushed
the
COIN-2785
branch
4 times, most recently
from
f18b702 to
47e6e9c
Compare
kamleshmugdiya
force-pushed
the
COIN-2785
branch
from
47e6e9c to
88d8f0e
Compare
kamleshmugdiya
force-pushed
the
COIN-2785
branch
5 times, most recently
from
96398b1 to
b98851f
Compare
kamleshmugdiya
force-pushed
the
COIN-2785
branch
from
b98851f to
6c5f1db
Compare
ewangbitgo
approved these changes
Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TICKET: COIN-2785