-
Notifications
You must be signed in to change notification settings - Fork 296
feat(sdk-coin-ton): add jetton skeleton #6618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
5b07d70
to
a17ad7e
Compare
modules/statics/src/account.ts
Outdated
@@ -630,6 +634,17 @@ export class Nep141Token extends AccountCoinToken { | |||
} | |||
} | |||
|
|||
export class JettonToken extends AccountCoinToken { | |||
public contractAddress: string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please check whether contractAddress
is the terminology used in Ton?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't use contractAddress in ton, We use Jetton Master contract. I will replace the contractAddress with the Jetton master.
import { Transaction } from './lib'; | ||
import { Ton } from './ton'; | ||
|
||
export class JettonToken extends Ton { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we name it JettonToken or TonToken?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think TonToken would be the appropriate name, I will make the necessary changes, thanks.
a17ad7e
to
e40b4e1
Compare
e40b4e1
to
305d75f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Ticket: WIN-3198
TICKET: WIN-3198