Skip to content

Conversation

@mohammadalfaiyazbitgo
Copy link
Contributor

@mohammadalfaiyazbitgo mohammadalfaiyazbitgo commented Oct 4, 2025

TICKET: WP-6188

Tested with BTC & ETH Hot Wallets.

@mohammadalfaiyazbitgo mohammadalfaiyazbitgo force-pushed the WP-6188/add-sign-verification-options branch from 1285579 to c4e79ce Compare October 4, 2025 04:11
@mohammadalfaiyazbitgo mohammadalfaiyazbitgo force-pushed the WP-6188/add-sign-verification-options branch from c4e79ce to fa8f983 Compare October 29, 2025 02:37
@mohammadalfaiyazbitgo mohammadalfaiyazbitgo marked this pull request as ready for review October 29, 2025 02:38
@mohammadalfaiyazbitgo mohammadalfaiyazbitgo requested review from a team as code owners October 29, 2025 02:38
@mohammadalfaiyazbitgo mohammadalfaiyazbitgo force-pushed the WP-6188/add-sign-verification-options branch from fa8f983 to cb4aa9f Compare October 29, 2025 13:51
@mohammadalfaiyazbitgo mohammadalfaiyazbitgo requested a review from a team as a code owner October 29, 2025 13:51
Copy link
Contributor

@margueriteblair margueriteblair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine to me, do we have plans for E2E testing in a lower env?

Marzooqa
Marzooqa previously approved these changes Oct 29, 2025
Copy link
Contributor

@OttoAllmendinger OttoAllmendinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please don't add magic binary blobs in tests

this is testing very utxo specific code and belongs in abstract-utxo

however this particular func already is extensively tested. Here you can just setup a sinon spy and ensure it gets called.

@mohammadalfaiyazbitgo
Copy link
Contributor Author

please don't add magic binary blobs in tests

this is testing very utxo specific code and belongs in abstract-utxo

however this particular func already is extensively tested. Here you can just setup a sinon spy and ensure it gets called.

done.

@mohammadalfaiyazbitgo
Copy link
Contributor Author

This seems fine to me, do we have plans for E2E testing in a lower env?

Yes, I tested build & signing a transaction on eth & btc hot wallets on test, and followed up with sending a transaction with 'sendMany' to make downstream functions didn't break.

@mohammadalfaiyazbitgo mohammadalfaiyazbitgo merged commit 64a2c84 into master Oct 30, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants