- 
                Notifications
    You must be signed in to change notification settings 
- Fork 300
feat(sdk-core): add verification options for signing txHex #7164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sdk-core): add verification options for signing txHex #7164
Conversation
1285579    to
    c4e79ce      
    Compare
  
    c4e79ce    to
    fa8f983      
    Compare
  
    fa8f983    to
    cb4aa9f      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems fine to me, do we have plans for E2E testing in a lower env?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please don't add magic binary blobs in tests
this is testing very utxo specific code and belongs in abstract-utxo
however this particular func already is extensively tested. Here you can just setup a sinon spy and ensure it gets called.
        951fbbc
      
    cb4aa9f    to
    951fbbc      
    Compare
  
    | 
 done. | 
| 
 Yes, I tested build & signing a transaction on eth & btc hot wallets on test, and followed up with sending a transaction with 'sendMany' to make downstream functions didn't break. | 
TICKET: WP-6188
Tested with BTC & ETH Hot Wallets.