Skip to content

fix(utxo-lib): use correct sign method for BIP-0327 test functions #7291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 22, 2025
Merged

fix(utxo-lib): use correct sign method for BIP-0327 test functions #7291

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 10 additions & 12 deletions modules/utxo-lib/bip-0327/reference.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -929,19 +929,18 @@ def sign_and_verify_with_aggpk_bitgo(
sk_1: bytes,
sk_2: bytes,
pk_1: PlainPk,
pk_2: PlainPk,
legacy_agg: bool = False
pk_2: PlainPk,
) -> None:
sign_and_verify_with_aggpk(
aggpk,
sk_1,
sk_2,
pk_1,
pk_2,
0,
random_nonce=False,
tweaks=[],
is_xonly=[])
sk_2,
pk_1,
pk_2,
0,
random_nonce=False,
tweaks=[],
is_xonly=[])

def sign_and_verify_with_aggpk_bitgo_legacy(
aggpk: XonlyPk,
Expand Down Expand Up @@ -1017,13 +1016,12 @@ def test_agg_bitgo_p2tr_legacy() -> None:
aggregated_xonly = get_xonly_pk(keyagg_ctx)
assert aggregated_xonly == expected_internal_pubkey_p2tr, \
f"p2tr aggregation mismatch: expected {expected_internal_pubkey_p2tr.hex()}, got {aggregated_xonly.hex()}"
sign_and_verify_with_aggpk_bitgo(
sign_and_verify_with_aggpk_bitgo_legacy(
expected_internal_pubkey_p2tr,
privkey_bitgo,
privkey_user,
pubkey_bitgo,
pubkey_user,
legacy_agg=True,
pubkey_user,
)

# Aggregation with keys in reverse order yields same result
Expand Down