Usability issue with sequence ids #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue where broadcasting a tx with a sequence id exactly 10,000 higher than the lowest value in
recentSequenceIdswill result in subsequent calls togetNextSequenceIdreturning an unusable sequenceId because of the final check intryInsertSequenceId.To verify, reference the branch in justinbretting#1, which shows how running
npm run truffle-testwill fail after a tx is successfully broadcast as described above.Note that even in this case, funds are not locked. However, the user(s) will need to have advanced knowledge of prior transactions executed against the contract to understand the current state of
recentSequenceIdsso a usable seq id can be used.