Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(eth-multisig-v4): add bera config #169

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore(eth-multisig-v4): add bera config #169

wants to merge 1 commit into from

Conversation

adarsh312
Copy link
Contributor

Ticket: WIN-3295

gianchandania
gianchandania requested changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@gianchandania gianchandania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is not needed as we have to deploy v4 contracts, and these keys are used for v1

@dpkjnr
Copy link
Contributor

dpkjnr commented Aug 22, 2024

I think this is not needed as we have to deploy v4 contracts, and these keys are used for v1

we don't need to deploy v1 contracts? I think it might be needed for cross chain recovery

@gianchandania
Copy link
Contributor

I think this is not needed as we have to deploy v4 contracts, and these keys are used for v1

we don't need to deploy v1 contracts? I think it might be needed for cross chain recovery

Ideally right now while developing berachain, we just deploy v4 contracts. v1 and v2 contracts are generally deployed later once cross chain work related to bera is taken up

@dpkjnr
Copy link
Contributor

dpkjnr commented Aug 22, 2024

I think this is not needed as we have to deploy v4 contracts, and these keys are used for v1

we don't need to deploy v1 contracts? I think it might be needed for cross chain recovery

Ideally right now while developing berachain, we just deploy v4 contracts. v1 and v2 contracts are generally deployed later once cross chain work related to bera is taken up

any idea why v1 script is getting executed even though tag is about v4? @gianchandania

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gianchandania gianchandania gianchandania requested changes

@dpkjnr dpkjnr dpkjnr approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adarsh312 @dpkjnr @gianchandania