Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(deploy): v1 factory contracts on avaxc testnet #178

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

feat(deploy): v1 factory contracts on avaxc testnet #178

wants to merge 3 commits into from

Conversation

mullapudipruthvik
Copy link
Contributor

Ticket: COIN-1712

kamleshmugdiya
kamleshmugdiya reviewed Sep 18, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
kamleshmugdiya
kamleshmugdiya reviewed Sep 18, 2024
View reviewed changes
Copy link
Contributor

@kamleshmugdiya kamleshmugdiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you test this locally?

@mullapudipruthvik
Copy link
Contributor Author

did you test this locally?

yes

@kamleshmugdiya
Copy link
Contributor

please resolve the conflicts.

@mullapudipruthvik
Copy link
Contributor Author

please resolve the conflicts.

there's no need to merge this PR, since tag will be created from this branch

@the-smooth-operator
Copy link
Contributor

Approved in https://bitgoinc.atlassian.net/browse/COIN-1712

kamleshmugdiya
kamleshmugdiya approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@kamleshmugdiya kamleshmugdiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamleshmugdiya kamleshmugdiya kamleshmugdiya approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
do-not-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mullapudipruthvik @kamleshmugdiya @the-smooth-operator