OpenCAP sending feature added #409

wagslane · 2018-10-25T05:50:39Z

Added the option for users to send directly to OpenCAP aliases. An OpenCAP alias is human-readable, looks like an email address, and can represent BTC/BCH addresses even as they update for each transaction. OpenCAP is an open-source protocol, and as such anyone can run their own OpenCAP server (it would be awesome if bitcoin.com hosted one at some point in the future)

For testing purposes, feel free to use https://ogdolo.com as it is a fully DNSSEC secured free OpenCAP server.

OpenCAP protocol: https://github.com/opencap/protocol

jbdtky · 2018-10-30T05:49:25Z

Thanks for your proposal. Our team will let you know.

jbdtky · 2018-10-30T05:57:53Z

src/js/services/opencapService.js

@@ -0,0 +1,160 @@
+'use strict';


Your service doesn't follow our standards.
https://github.com/Bitcoin-com/Wallet/blob/master/src/js/services/shapeshift.service.js
The link below is an example of our standard for a service.

If you want to use a promise, use the promise from Angular1 provided by $q.
Example
var deferred = $q.defer(); ... deferred.resolve(res); deferred.reject(err); ... return deferred.promise;

If you want make a http request, please use $http from Angular1 instead of fetch.

file naming convention opencap.service.js

declare your module in bitcoincom.services

Perfect. I'll work on this, thanks!

Just finished the update. I covered all of your points, let me know if there is anything else you want changed!

Thanks, I will review it and let you know. I don't guarantee anything, I will review technically if it is suitable to our app.

Sounds good. I'll keep an eye if you need more changes made.

wagslane · 2018-12-03T02:00:36Z

Just finished adding the CashAddr format, as well as a more friendly UI/UX for aliases (they now use the same input field)

jchau207 · 2018-12-17T09:09:41Z

Can one of the admins verify this patch?

jbdtky · 2019-01-07T02:47:48Z

src/js/services/opencap.service.js

+
+ var parseAddresses = function(respData, dnssec) {
+ let addresses = {}
+ return $q((resolve, reject) => {


Now : => : lambda expression is not supported for old javascript engine.
Should be :

function onQ() { }

jbdtky · 2019-01-07T02:48:10Z

src/js/services/opencap.service.js

+ parseSRV(response.data)
+ .then(data => getAddresses(alias, data.host, data.dnssec))
+ .catch(function(error) {
+ return $q((resolve, reject) => {


Now : => : lambda expression is not supported for old javascript engine.
Should be :

function onQ() { }

jbdtky · 2019-01-07T02:48:18Z

src/js/services/opencap.service.js

+ function getAddress(alias) {
+ let aliasData = validateAlias(alias);
+ if (aliasData.username === '' || aliasData.domain === '') {
+ return $q((resolve, reject) => {


Now : => : lambda expression is not supported for old javascript engine.
Should be :

function onQ() { }

jbdtky · 2019-01-07T02:48:39Z

src/js/services/opencap.service.js

+ .then(function(response) {
+ deferred.resolve(
+ parseSRV(response.data)
+ .then(data => getAddresses(alias, data.host, data.dnssec))


Now : => : lambda expression is not supported for old javascript engine.
Should be :

function onThen() { }

jbdtky · 2019-01-07T02:48:52Z

src/js/controllers/tab-send.controller.js

+ popover.show(angular.element(document.querySelector('#search-input')))
+ });
+ })
+ .catch(status => {


Now : => : lambda expression is not supported for old javascript engine.
Should be :

function onCatch() { }

jbdtky · 2019-01-07T02:51:48Z

src/js/services/opencap.service.js

+ return deferred.promise;
+ }
+
+ var parseSRV = function(respData) {


Now : var parseSRV = function(
Should be : function parseSRV(

jbdtky · 2019-01-07T02:52:15Z

src/js/services/opencap.service.js

+ });
+ };
+
+ var getAddresses = function(alias, host, dnssec) {


Now : var getAddresses = function(
Should be : function getAddresses(

jbdtky · 2019-01-07T02:52:22Z

src/js/services/opencap.service.js

+ let deferred = $q.defer();
+ $http
+ .get(`https://${host}/v1/addresses?alias=${alias}`)
+ .then(function(response) {


Now : function(
Should be : function onThen(

jbdtky · 2019-01-07T02:52:30Z

src/js/services/opencap.service.js

+ .then(function(response) {
+ deferred.resolve(parseAddresses(response.data, dnssec).then());
+ })
+ .catch(function(response) {


Now : function(
Should be : function onCatch(

jbdtky · 2019-01-07T02:53:01Z

src/js/services/opencap.service.js

+ return deferred.promise;
+ };
+
+ var parseAddresses = function(respData, dnssec) {


Now : var parseAddresses = function(
Should be : function parseAddresses(

I think I got it all addressed

jbdtky · 2019-01-07T05:56:03Z

We have written this var parsed = bitcoinUriService.parse(text);
The perfect place for calling your protocol should be in the bitcoinUriService, you should not need to change anything else (src/js/controllers/tab-send.controller.js)

wagslane · 2019-01-07T06:22:01Z

We have written this var parsed = bitcoinUriService.parse(text);
The perfect place for calling your protocol should be in the bitcoinUriService, you should not need to change anything else (src/js/controllers/tab-send.controller.js)

I actually don't think it belongs there... Looks like that functions returns an object, where I need to return a promise right?

wagslane · 2019-02-13T17:26:02Z

Just fixed a merge conflict that came up recently. Have you had a chance to look at my question above? I think they way I have it may be correct (needs to be a promise returned)

This reverts commit 16aa33e.

wagslane added 2 commits October 24, 2018 23:30

added opencap support

0993ab1

fix btc bug

26bb49d

jbdtky suggested changes Oct 30, 2018

View reviewed changes

wagslane added 3 commits October 31, 2018 15:51

confirm to bitcoin-com style

741fc13

Merge branch 'master' of https://github.com/Bitcoin-com/Wallet

c906747

add cashaddr, use popover

45bcde9

moshi1980 approved these changes Dec 17, 2018

View reviewed changes

jbdtky suggested changes Jan 7, 2019

View reviewed changes

wagslane added 3 commits January 6, 2019 22:01

Merge branch 'master' of https://github.com/Bitcoin-com/Wallet

31aa175

no arrows

7749479

no var functions

cd580cd

missed one

1d9e897

wagslane added 2 commits February 13, 2019 10:24

merge latest

b179c33

merge latest conflicts

091990b

Angel Mortega added 2 commits March 28, 2019 16:32

Set package dependencies versions to fixed versions.

16aa33e

Revert "Set package dependencies versions to fixed versions."

ea19d10

This reverts commit 16aa33e.

thinesugi approved these changes Mar 30, 2019

View reviewed changes

wagslane added 2 commits March 29, 2019 19:46

conflict

adbe7b5

linting

6122cfa

jbdtky force-pushed the master branch from ea19d10 to 771a127 Compare April 2, 2019 04:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

OpenCAP sending feature added #409

OpenCAP sending feature added #409

wagslane commented Oct 25, 2018

jbdtky commented Oct 30, 2018

jbdtky Oct 30, 2018

wagslane Oct 30, 2018

wagslane Oct 31, 2018

jbdtky Jan 7, 2019

wagslane Jan 7, 2019

wagslane commented Dec 3, 2018

jchau207 commented Dec 17, 2018

jbdtky Jan 7, 2019

jbdtky Jan 7, 2019

jbdtky Jan 7, 2019

jbdtky Jan 7, 2019

jbdtky Jan 7, 2019

jbdtky Jan 7, 2019

jbdtky Jan 7, 2019

jbdtky Jan 7, 2019

jbdtky Jan 7, 2019

jbdtky Jan 7, 2019

wagslane Jan 7, 2019

jbdtky commented Jan 7, 2019 •

edited

Loading

wagslane commented Jan 7, 2019

wagslane commented Feb 13, 2019

OpenCAP sending feature added #409

Are you sure you want to change the base?

OpenCAP sending feature added #409

Conversation

wagslane commented Oct 25, 2018

jbdtky commented Oct 30, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wagslane commented Dec 3, 2018

jchau207 commented Dec 17, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jbdtky commented Jan 7, 2019 • edited Loading

wagslane commented Jan 7, 2019

wagslane commented Feb 13, 2019

jbdtky commented Jan 7, 2019 •

edited

Loading