Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is mocha dependency necessary to run bitbox? #120

Closed
devalbo opened this issue Jun 8, 2019 · 1 comment
Closed

Is mocha dependency necessary to run bitbox? #120

devalbo opened this issue Jun 8, 2019 · 1 comment

Comments

@devalbo
Copy link

devalbo commented Jun 8, 2019

I upgraded to bitbox-sdk 8.4.0 in my react/Typescript project and I think @types/mocha dependency is causing a conflict with my jest dependency. According to my package-lock.json, @types/mocha is needed by bitbox-sdk. Is this actually true? Or can you make it a dev dependency?
cgcardona pushed a commit that referenced this issue Jun 19, 2019
* Move mocha types dep to dev dependencies per this issue: #120
bcf7ae3
@cgcardona
Copy link

Thanks for pointing this out. I moved the types for mocha, chai and sinon to dev dependencies. The fix is in bitbox-sdk v8.4.2

🎩

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cgcardona @devalbo