Add home page banner full-width background images option #271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To accommodate new banner design by Rama.
GBKS
added
Dev
Collaborator
|
LGTM |
Contributor
|
Looks good to me! |
Contributor
|
I'm really digging the mixed style here. I'm curious why the statue person is not interested though 😅 How do credits work for such kind of artwork since it's a composite? Do we need references to the source images? |
Contributor
Author
|
@johnsBeharry the author name is always linked to the issue in which the design was proposed. In there, we should ensure to properly attribute all images used. |
Contributor
Author
|
Updated with design tweaks by Rama, a proper name for the theme ("The Meta-Future"), and the correct link to the issue where Rama proposed the design. Should be good to go now if people like it. |
ConorOkus
approved these changes
May 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To accommodate new banner design by Rama, which is also implemented here to showcase this functionality.
Don't merge this until the banner theme is actually finalized. Need to review this with Rama.
Closes #260